| commit | daac106699e16d3dbcea640b412af097f051a8e1 | [log] [tgz] |
|---|---|---|
| author | Paul Lewis <[email protected]> | Thu Mar 05 14:37:10 2020 |
| committer | Commit Bot <[email protected]> | Thu Mar 05 14:58:03 2020 |
| tree | 46b474960d686f15266d639de3b870d2efede091 | |
| parent | b0d65f1b3c4057f3ddbef0bb8974dfa4131e3b42 [diff] [blame] |
[global] Remaps self.SDK.targetManager This CL changes references to self.SDK.targetManager (the global instance of SDK.SDKModel.TargetManager) over to SDK.SDKModel.TargetManager.instance(). To keep both TypeScript and Closure happy we must make a method on the TargetManager class itself, since it only allows private constructors to be accessed by static methods on the class. Bug: 1058320 Change-Id: I6ca35024c21cf24254fd6273138a1ab3e163ee00 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088092 Commit-Queue: Paul Lewis <[email protected]> Reviewed-by: Tim van der Lippe <[email protected]>
diff --git a/front_end/network/BlockedURLsPane.js b/front_end/network/BlockedURLsPane.js index 948ec79..b269d9cc 100644 --- a/front_end/network/BlockedURLsPane.js +++ b/front_end/network/BlockedURLsPane.js
@@ -47,7 +47,7 @@ /** @type {!Map<string, number>} */ this._blockedCountForUrl = new Map(); - self.SDK.targetManager.addModelListener( + SDK.SDKModel.TargetManager.instance().addModelListener( SDK.NetworkManager.NetworkManager, SDK.NetworkManager.Events.RequestFinished, this._onRequestFinished, this); this._updateThrottler = new Common.Throttler.Throttler(200);