[global] Remaps self.SDK.targetManager
This CL changes references to self.SDK.targetManager (the global
instance of SDK.SDKModel.TargetManager) over to
SDK.SDKModel.TargetManager.instance(). To keep both TypeScript and
Closure happy we must make a method on the TargetManager class itself,
since it only allows private constructors to be accessed by static
methods on the class.
Bug: 1058320
Change-Id: I6ca35024c21cf24254fd6273138a1ab3e163ee00
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2088092
Commit-Queue: Paul Lewis <[email protected]>
Reviewed-by: Tim van der Lippe <[email protected]>
diff --git a/front_end/web_audio/WebAudioView.js b/front_end/web_audio/WebAudioView.js
index aee109f..aa3fe8f 100644
--- a/front_end/web_audio/WebAudioView.js
+++ b/front_end/web_audio/WebAudioView.js
@@ -56,7 +56,7 @@
this.doUpdate();
});
- self.SDK.targetManager.observeModels(WebAudioModel, this);
+ SDK.SDKModel.TargetManager.instance().observeModels(WebAudioModel, this);
}
/**
@@ -64,7 +64,7 @@
*/
wasShown() {
super.wasShown();
- for (const model of self.SDK.targetManager.models(WebAudioModel)) {
+ for (const model of SDK.SDKModel.TargetManager.instance().models(WebAudioModel)) {
this._addEventListeners(model);
}
}
@@ -73,7 +73,7 @@
* @override
*/
willHide() {
- for (const model of self.SDK.targetManager.models(WebAudioModel)) {
+ for (const model of SDK.SDKModel.TargetManager.instance().models(WebAudioModel)) {
this._removeEventListeners(model);
}
}
@@ -392,7 +392,7 @@
return;
}
- for (const model of self.SDK.targetManager.models(WebAudio.WebAudioModel)) {
+ for (const model of SDK.SDKModel.TargetManager.instance().models(WebAudio.WebAudioModel)) {
// Display summary only for real-time context.
if (context.contextType === 'realtime') {
if (!this._graphManager.hasContext(context.contextId)) {
