| commit | e10a94c154cb39dcbf9f35c49a013bc01a49222d | [log] [tgz] |
|---|---|---|
| author | Danil Somsikov <[email protected]> | Mon Mar 11 08:31:32 2024 |
| committer | Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 11 09:24:08 2024 |
| tree | 32d829a6d88080eee95849254e66368eadf02ef1 | |
| parent | 7b94fc6bd96809ac182cfeaa6898e0ef9fef71a4 [diff] |
[ve] Fix the keyboard navigation to the initiator column This got broken in the crrev.com/c/5339956 Bug: chromium:1467464 Change-Id: I0048dcd32244f80b3af553956f4a3f79fca9f11f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5358035 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Commit-Queue: Danil Somsikov <[email protected]> Auto-Submit: Danil Somsikov <[email protected]>
diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts index 11e558e..99d05c7 100644 --- a/front_end/panels/network/NetworkLogView.ts +++ b/front_end/panels/network/NetworkLogView.ts
@@ -1117,7 +1117,7 @@ this.dataGrid.element.addEventListener('mouseleave', () => this.setHoveredNode(null), true); this.dataGrid.element.addEventListener('keydown', event => { if (event.key === 'ArrowRight' && this.dataGrid.selectedNode) { - const initiatorLink = this.dataGrid.selectedNode.element().querySelector('span.devtools-link'); + const initiatorLink = this.dataGrid.selectedNode.element().querySelector('button.devtools-link'); if (initiatorLink) { (initiatorLink as HTMLElement).focus(); }
diff --git a/front_end/panels/network/networkLogView.css b/front_end/panels/network/networkLogView.css index a45e233..1f5c766 100644 --- a/front_end/panels/network/networkLogView.css +++ b/front_end/panels/network/networkLogView.css
@@ -141,8 +141,12 @@ color: inherit; } -.initiator-column .devtools-link { +.initiator-column .text-button.devtools-link, +.initiator-column .text-button.devtools-link:focus-visible { color: inherit; + background-color: transparent; + outline-offset: 0; + height: 16px; } .network-error-row,