commit e71698ba79bfda112a764e3af26414941eaafff9
author Kim-Anh Tran <kimanh@chromium.org> Wed Apr 17 07:43:52 2024
committer Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 17 08:42:30 2024
tree 7fc05d11a8fdfa6b5fc82ee8c16ac231d2b0f9f9
parent 2fbf69efd358149dddd9ce7dc9cb9a80fa61c763

[GM3Restyling] Use ToolbarFilter instead of ToolbarInput for filters

This changes all usages of ToolbarInput as filters to ToolbarFilter.
One ToolbarInput is remaining for ProtocolMonitor, which we will
update at a later stage when looking at Text Fields.

Before: https://imgur.com/aeAoTVS
After: https://i.imgur.com/YjBbjCn.gif
Bug: 325442270
Change-Id: I41c709c220d7ab9e28a6c579a089c8f57db821be
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5402575
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>

test/e2e/helpers/memory-helpers.ts

diff --git a/test/e2e/helpers/memory-helpers.ts b/test/e2e/helpers/memory-helpers.ts
index f1b9781..6caff91 100644
--- a/test/e2e/helpers/memory-helpers.ts
+++ b/test/e2e/helpers/memory-helpers.ts
@@ -24,7 +24,7 @@
 const MEMORY_PANEL_CONTENT = 'div[aria-label="Memory panel"]';
 const PROFILE_TREE_SIDEBAR = 'div.profiles-tree-sidebar';
 export const MEMORY_TAB_ID = '#tab-heap-profiler';
-const CLASS_FILTER_INPUT = 'div[aria-placeholder="Class filter"]';
+const CLASS_FILTER_INPUT = 'div[aria-placeholder="Filter by class"]';
 const SELECTED_RESULT = '#profile-views table.data tr.data-grid-data-grid-node.revealed.parent.selected';
 
 export async function navigateToMemoryTab() {

test/e2e/helpers/performance-helpers.ts

diff --git a/test/e2e/helpers/performance-helpers.ts b/test/e2e/helpers/performance-helpers.ts
index 9b63556..9ce12ab 100644
--- a/test/e2e/helpers/performance-helpers.ts
+++ b/test/e2e/helpers/performance-helpers.ts
@@ -17,7 +17,7 @@
   waitForMany,
 } from '../../shared/helper.js';
 
-export const FILTER_TEXTBOX_SELECTOR = '[aria-label="Filter bottom-up"]';
+export const FILTER_TEXTBOX_SELECTOR = '[aria-label="Filter"]';
 export const RECORD_BUTTON_SELECTOR = '[aria-label="Record"]';
 export const RELOAD_AND_RECORD_BUTTON_SELECTOR = '[aria-label="Start profiling and reload page"]';
 export const STOP_BUTTON_SELECTOR = '[aria-label="Stop"]';

test/e2e/network/network-request-view_test.ts

diff --git a/test/e2e/network/network-request-view_test.ts b/test/e2e/network/network-request-view_test.ts
index 5d4ae7b..375f283 100644
--- a/test/e2e/network/network-request-view_test.ts
+++ b/test/e2e/network/network-request-view_test.ts
@@ -279,7 +279,7 @@
     let messages = await waitForMessages(messagesView, 3);
     await assertBaseState(messagesView);
 
-    const inputSelector = '[aria-placeholder="Enter regex, for example: https?';
+    const inputSelector = '[aria-placeholder="Filter using regex (example: https?)';
 
     const filterInput = await waitFor(inputSelector, messagesView);
 
@@ -348,7 +348,7 @@
     let messages = await waitForMessages(4);
 
     const filterInput =
-        await waitFor('[aria-label="Enter regex, for example: (web)?socket"][role=textbox]', messagesView);
+        await waitFor('[aria-label="Filter using regex (example: (web)?socket)"][role=textbox]', messagesView);
     await filterInput.focus();
     await typeText('ping');