| commit | e92fe9d74570d2df08698f7e62ae834d01747ae5 | [log] [tgz] |
|---|---|---|
| author | Alex Rudenko <[email protected]> | Mon Jan 30 13:12:23 2023 |
| committer | Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 30 14:27:54 2023 |
| tree | e7e71402e2bbd4f97f5e9805dcf468025963c482 | |
| parent | 0801f17e15d0ef3bf9fdc473fd114c66c66aa456 [diff] [blame] |
Refactor the click helper to use Puppeteer's methods The click helper now only accepts selectors so that it is able to recover from unstable DOM situations. A new deprecated helper clickElement is introduced for tests that cannot use a selector currently. This should serve as a red flag that the test might suffer from flakiness. Bounding box and offset computation is removed for now. New Puppeteer version allows providing relative click coordinates so we need to use that. Bug: 1411188, 1409768, 1411196, 1410437 Change-Id: I94a272184530842476bb2a879d862c4bd0930dba Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4194329 Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Alex Rudenko <[email protected]>
diff --git a/test/e2e/helpers/performance-helpers.ts b/test/e2e/helpers/performance-helpers.ts index 29ff580..c62db5a 100644 --- a/test/e2e/helpers/performance-helpers.ts +++ b/test/e2e/helpers/performance-helpers.ts
@@ -90,6 +90,5 @@ } export async function clickOnFunctionLink() { - const link = await waitFor('.timeline-details.devtools-link'); - await click(link); + await click('.timeline-details.devtools-link'); }