Type histogram name argument of recordEnumeratedHistogram
This CL exposed an hard-to-find bug fixed in:
https://crrev.com/c/2275454
Bug: chromium:1098736
Change-Id: Icf512f61854e855566e070cc592af59168d85f08
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2278466
Commit-Queue: Sigurd Schneider <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
diff --git a/front_end/devtools_compatibility.js b/front_end/devtools_compatibility.js
index 11e081e..6ede9e8 100644
--- a/front_end/devtools_compatibility.js
+++ b/front_end/devtools_compatibility.js
@@ -356,6 +356,22 @@
// InspectorFrontendHostImpl --------------------------------------------------
/**
+ * Enum for recordPerformanceHistogram
+ * Warning: There are three definitions of this enum in the DevTools code base, keep them in sync.
+ * @readonly
+ * @enum {string}
+ */
+ const EnumeratedHistogram = {
+ ActionTaken: 'DevTools.ActionTaken',
+ PanelShown: 'DevTools.PanelShown',
+ KeyboardShortcutFired: 'DevTools.KeyboardShortcutFired',
+ IssuesPanelOpenedFrom: 'DevTools.IssuesPanelOpenedFrom',
+ KeybindSetSettingChanged: 'DevTools.KeybindSetSettingChanged',
+ DualScreenDeviceEmulated: 'DevTools.DualScreenDeviceEmulated',
+ GridSettingChanged: 'DevTools.GridSettingChanged',
+ };
+
+ /**
* @implements {InspectorFrontendHostAPI}
* @unrestricted
*/
@@ -570,13 +586,12 @@
/**
* @override
- * @param {string} actionName
+ * @param {!InspectorFrontendHostAPI.EnumeratedHistogram} actionName
* @param {number} actionCode
* @param {number} bucketSize
*/
recordEnumeratedHistogram(actionName, actionCode, bucketSize) {
- // Support for M49 frontend.
- if (actionName === 'DevTools.DrawerShown') {
+ if (!Object.values(EnumeratedHistogram).includes(actionName)) {
return;
}
DevToolsAPI.sendMessageToEmbedder('recordEnumeratedHistogram', [actionName, actionCode, bucketSize], null);
