commit ffd1424ae5737c0035102b48fe2bd8e888091c6b
author Randolf Jung <jrandolf@chromium.org> Wed Apr 19 00:32:25 2023
committer Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Apr 19 09:56:42 2023
tree f6c96307e73be490aad9a68dea75ad8c7908d0e8
parent 1f38275ef3e38c6603d7be4b96672ceb9a158c2c

Add `noImplicitOverride`

`noImplicitOverride` guarantees type safety when overriding a class method. This also improves refactoring behavior.

The primary motivation for `noImplicitOverride` is for using with Lit elements where overriding methods is important.

Bug: 1402569
Change-Id: Ia095c38a6d1fc160f9b08c350d6f7248daab38a4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4443322
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Randolf Jung <jrandolf@chromium.org>

front_end/panels/network/NetworkLogView.ts

diff --git a/front_end/panels/network/NetworkLogView.ts b/front_end/panels/network/NetworkLogView.ts
index 217ee44..5e7397c 100644
--- a/front_end/panels/network/NetworkLogView.ts
+++ b/front_end/panels/network/NetworkLogView.ts
@@ -966,7 +966,7 @@
     UI.ARIAUtils.setHidden(this.summaryToolbarInternal.element, value);
   }
 
-  elementsToRestoreScrollPositionsFor(): Element[] {
+  override elementsToRestoreScrollPositionsFor(): Element[] {
     if (!this.dataGrid)  // Not initialized yet.
     {
       return [];
@@ -1244,17 +1244,17 @@
     }
   }
 
-  wasShown(): void {
+  override wasShown(): void {
     this.refreshIfNeeded();
     this.registerCSSFiles([networkLogViewStyles]);
     this.columnsInternal.wasShown();
   }
 
-  willHide(): void {
+  override willHide(): void {
     this.columnsInternal.willHide();
   }
 
-  onResize(): void {
+  override onResize(): void {
     this.rowHeightInternal = this.computeRowHeight();
   }