Browse code

missing(...) replaces length(list(...)) == 0

git-svn-id: file:///home/git/hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/Biobase@103388 bc3139a8-67e5-0310-9ffc-ced21a209358

Martin Morgan authored on 02/05/2015 22:14:07
Showing 3 changed files

... ...
@@ -1,6 +1,6 @@
1 1
 Package: Biobase
2 2
 Title: Biobase: Base functions for Bioconductor
3
-Version: 2.29.0
3
+Version: 2.29.1
4 4
 Author: R. Gentleman, V. Carey, M. Morgan, S. Falcon
5 5
 Description: Functions that are needed by many other packages or which
6 6
         replace R functions.
... ...
@@ -3,7 +3,7 @@
3 3
 
4 4
 setMethod("initialize", signature(.Object="VersionsNull"),
5 5
           function(.Object, ...) {
6
-              if (length(list(...)))
6
+              if (!missing(...))
7 7
                 warning("ignoring arguments to '.VersionsNull()')")
8 8
               .Object
9 9
           })
... ...
@@ -355,7 +355,7 @@ setMethod("[", "eSet", function(x, i, j, ..., drop = FALSE) {
355 355
   if (missing(drop))
356 356
     drop <- FALSE
357 357
   if (missing(i) && missing(j)) {
358
-      if (length(list(...))!=0)
358
+      if (!missing(...))
359 359
         stop("specify genes or samples to subset; use '",
360 360
              substitute(x), "$", names(list(...))[[1]],
361 361
              "' to access phenoData variables")