Browse code

Simplify import function

Gabriele Sales authored on 25/01/2023 16:33:04
Showing 8 changed files

... ...
@@ -1,7 +1,7 @@
1 1
 Package: spatialDE
2 2
 Title: R wrapper for SpatialDE
3
-Date: 2023-01-23
4
-Version: 1.5.1
3
+Date: 2023-01-25
4
+Version: 1.5.2
5 5
 Authors@R: c(
6 6
     person("Davide", "Corso", role = "aut",
7 7
            email = "[email protected]",
... ...
@@ -21,7 +21,7 @@ License: MIT + file LICENSE
21 21
 Encoding: UTF-8
22 22
 LazyData: FALSE
23 23
 Roxygen: list(markdown = TRUE)
24
-RoxygenNote: 7.2.1
24
+RoxygenNote: 7.2.3
25 25
 URL: https://github.com/sales-lab/spatialDE, https://bioconductor.org/packages/spatialDE/
26 26
 BugReports: https://github.com/sales-lab/spatialDE/issues
27 27
 Depends: R (>= 4.1)
... ...
@@ -111,7 +111,7 @@ NULL
111 111
     
112 112
     coordinates <- sample_info[, c("x", "y")]
113 113
     
114
-    .importPyModule(proc, !verbose, .set_fake_tqdm, .set_real_tqdm)
114
+    .importPyModule(proc, !verbose)
115 115
     .spatialDE_spatial_patterns(
116 116
         proc = proc, 
117 117
         x = regressed, coordinates = coordinates,
... ...
@@ -59,7 +59,7 @@ model_search <- function(x,
59 59
     }
60 60
     
61 61
     proc <- basiliskStart(spatialDE_env, testload="scipy.optimize")
62
-    .importPyModule(proc, !verbose, .set_fake_tqdm, .set_real_tqdm)
62
+    .importPyModule(proc, !verbose)
63 63
 
64 64
     .spatialDE_model_search(proc, x, coordinates, de_results)
65 65
     
... ...
@@ -157,7 +157,7 @@ spatial_patterns <- function(x, coordinates, de_results,
157 157
     }
158 158
     
159 159
     proc <- basiliskStart(spatialDE_env, testload="scipy.optimize")
160
-    .importPyModule(proc, !verbose, .set_fake_tqdm, .set_real_tqdm)
160
+    .importPyModule(proc, !verbose)
161 161
     
162 162
     .spatialDE_spatial_patterns(proc, x, coordinates, de_results, n_patterns, 
163 163
                                 length)
... ...
@@ -20,21 +20,20 @@ SpatialDE.base.tqdm = tqdm.autonotebook.tqdm
20 20
 #'
21 21
 #' @param proc A process object generated by [`basilisk::basiliskStart()`]
22 22
 #' @param patch_tqdm If `TRUE` patch calls to tqdm.
23
-#' @param set_fake_tqdm
24
-#' @param set_real_tqdm
25 23
 #' @return An R wrapper for the SpatialDE Python module.
26 24
 #'
27 25
 #' @importFrom reticulate import py_run_string
28 26
 #' @importFrom basilisk basiliskRun
29 27
 #'
30 28
 #' @keywords internal
31
-.importPyModule <- function(proc, patch_tqdm, set_fake_tqdm, set_real_tqdm) {
32
-  basiliskRun(proc, function(patch_tqdm, set_fake_tqdm, set_real_tqdm, store) {
29
+.importPyModule <- function(proc, patch_tqdm) {
30
+  imp <- function(patch_tqdm, store) {
33 31
     mod <- import("SpatialDE")
34
-    py_run_string(ifelse(patch_tqdm, set_fake_tqdm, set_real_tqdm))
32
+    py_run_string(ifelse(patch_tqdm, .set_fake_tqdm, .set_real_tqdm))
35 33
 
36 34
     store$spatialDE <- mod
37 35
     invisible(NULL)
38
-  }, patch_tqdm=patch_tqdm, set_fake_tqdm=set_fake_tqdm,
39
-  set_real_tqdm=set_fake_tqdm, persist=TRUE)
36
+  }
37
+
38
+  basiliskRun(proc, imp, patch_tqdm, persist=TRUE)
40 39
 }
... ...
@@ -93,7 +93,7 @@ NULL
93 93
     }, persist=TRUE)
94 94
 
95 95
     coordinates <- sample_info[, c("x", "y")]
96
-    .importPyModule(proc, !verbose, .set_fake_tqdm, .set_real_tqdm)
96
+    .importPyModule(proc, !verbose)
97 97
     .spatialDE_model_search(proc, regressed, coordinates, de_results)
98 98
     
99 99
     out <- basiliskRun(proc, function(store) {
... ...
@@ -49,7 +49,7 @@ run <- function(x, coordinates, verbose = FALSE) {
49 49
     
50 50
     proc <- basiliskStart(spatialDE_env, testload="scipy.optimize")
51 51
     
52
-    .importPyModule(proc, !verbose, .set_fake_tqdm, .set_real_tqdm)
52
+    .importPyModule(proc, !verbose)
53 53
     .spatialDE_run(proc, x, coordinates)
54 54
     
55 55
     out <- basiliskRun(proc, function(store) {
... ...
@@ -92,7 +92,7 @@ NULL
92 92
     assert_names(colnames(coords), identical.to = c("x", "y"))
93 93
     assert_matrix(regressed, any.missing = FALSE)
94 94
     assert_flag(verbose)
95
-    .importPyModule(proc, verbose, .set_fake_tqdm, .set_real_tqdm)
95
+    .importPyModule(proc, verbose)
96 96
     .spatialDE_run(proc, regressed, coords)
97 97
     
98 98
     # results
... ...
@@ -4,7 +4,7 @@
4 4
 \alias{.importPyModule}
5 5
 \title{Import SpatialDE}
6 6
 \usage{
7
-.importPyModule(proc, patch_tqdm, set_fake_tqdm, set_real_tqdm)
7
+.importPyModule(proc, patch_tqdm)
8 8
 }
9 9
 \arguments{
10 10
 \item{proc}{A process object generated by \code{\link[basilisk:basiliskStart]{basilisk::basiliskStart()}}}