Fixed #12142 -- EmptyQuerySet.update() no longer updates all rows in the database

adrianholovaty · adrianholovaty · commit cf1b6845d4cc · 2010-01-10T17:53:19.000Z
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12171 bcc190cf-cafb-0310-a4f2-bffc1f526a37
diff --git a/django/db/models/query.py b/django/db/models/query.py
@@ -1089,6 +1089,12 @@ def only(self, *fields):
         """
         return self
 
+    def update(self, **kwargs):
+        """
+        Don't update anything.
+        """
+        return 0
+
     # EmptyQuerySet is always an empty result in where-clauses (and similar
     # situations).
     value_annotation = False
diff --git a/tests/modeltests/lookup/models.py b/tests/modeltests/lookup/models.py
@@ -295,6 +295,8 @@ def __unicode__(self):
 []
 >>> Article.objects.none().count()
 0
+>>> Article.objects.none().update(headline="This should not take effect")
+0
 >>> [article for article in Article.objects.none().iterator()]
 []
 

Original file line number	Diff line number	Diff line change
`@@ -295,6 +295,8 @@ def __unicode__(self):`
`295`	`295`	`[]`
`296`	`296`	`>>> Article.objects.none().count()`
`297`	`297`	`0`
	`298`	`+>>> Article.objects.none().update(headline="This should not take effect")`
	`299`	`+0`
`298`	`300`	`>>> [article for article in Article.objects.none().iterator()]`
`299`	`301`	`[]`
`300`	`302`