diff options
| author | Mark Wielaard <[email protected]> | 2016-07-06 15:27:56 +0200 |
|---|---|---|
| committer | Mark Wielaard <[email protected]> | 2016-07-11 09:53:29 +0200 |
| commit | 8b5f017ddf1684e225ef59f9243ef411b2556e9c (patch) | |
| tree | b71828472ffda1fe441f2dcf6ac30da9ff769447 /src/unstrip.c | |
| parent | 96e140f6687922606657a76f185a73cf47908ef2 (diff) | |
libelf: Allow updating phdrs for any e_type.
elf[32|64]_updatenull would sanity check the e_type before allowing to
update the phdrs. This prevents creating an ET_REL file with phdrs. It
also prevents creating any vendor specific ELF file having phdrs. We
only check this when updating/writing out the file. But we would just
read such files. Don't prevent people from creating unexpected ELF files.
elflint will warn for such files.
While writing a new testcase for this another bug was found that
prevented updating a just created phdr because elf_getphdrnum would
sanity check the phdr offset in the file (which doesn't exist yet).
Fix that by only doing such a sanity check if the phdrs haven't been
read in or created yet.
This second bug should have been found by the existing elfshphehdr
test, but that test contained a typo checking elf_getphdrnum.
It tested that the called failed when there were no phdrs, but then
elf_getphdrnum should simply succeed and return zero.
https://bugzilla.redhat.com/show_bug.cgi?id=1352232
Signed-off-by: Mark Wielaard <[email protected]>
Diffstat (limited to 'src/unstrip.c')
0 files changed, 0 insertions, 0 deletions
