From a1f359ed0d456fc85f14d54e87a21ac9c0c4e553 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Thu, 18 Jun 2015 23:43:39 +0200 Subject: findtextrel: Don't leak memory in process_file. When a files do contain textrels we fail to release the segments searched and valgrind will show: 2,560 bytes in 16 blocks are definitely lost in loss record 1 of 1 at 0x40281B5: malloc (in vgpreload_memcheck-x86-linux.so) by 0x804AE63: process_file (findtextrel.c:322) by 0x804909B: main (findtextrel.c:149) Signed-off-by: Mark Wielaard --- src/ChangeLog | 4 ++++ src/findtextrel.c | 1 + 2 files changed, 5 insertions(+) diff --git a/src/ChangeLog b/src/ChangeLog index 80e451ce..7d5e001b 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2015-06-18 Mark Wielaard + + * findtextrel.c (process_file): Free segments after use. + 2015-06-18 Mark Wielaard * readelf.c (print_phdr): Make sure phdr2_mem lifetime/scope equals diff --git a/src/findtextrel.c b/src/findtextrel.c index 264a06bd..6f1a4b55 100644 --- a/src/findtextrel.c +++ b/src/findtextrel.c @@ -484,6 +484,7 @@ cannot get relocation at index %d in section %zu in '%s': %s"), if (fd2 != -1) close (fd2); + free (segments); tdestroy (knownsrcs, noop); return result; -- cgit v1.2.3