From 555e15ebe8bf1eb33d00747173cfc80cc65648a4 Mon Sep 17 00:00:00 2001 From: Joshua Watt Date: Fri, 9 Feb 2018 10:27:18 -0600 Subject: Use fallthrough attribute. Use __attribute__ ((fallthrough)) to indicate switch case fall through instead of a comment. This ensures that the fallthrough warning is not triggered even if the file is pre-processed (hence stripping the comments) before it is compiled. The actual fallback implementation is hidden behind a FALLBACK macro in case the compiler doesn't support it. Finally, the -Wimplict-fallthrough warning was upgraded to only allow the attribute to satisfy it; a comment alone is no longer sufficient. Signed-off-by: Joshua Watt --- backends/arm_regs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'backends/arm_regs.c') diff --git a/backends/arm_regs.c b/backends/arm_regs.c index 21c5ad3a..a46a4c99 100644 --- a/backends/arm_regs.c +++ b/backends/arm_regs.c @@ -77,7 +77,7 @@ arm_register_info (Ebl *ebl __attribute__ ((unused)), case 16 + 0 ... 16 + 7: regno += 96 - 16; - /* Fall through. */ + FALLTHROUGH; case 96 + 0 ... 96 + 7: *setname = "FPA"; *type = DW_ATE_float; -- cgit v1.2.3