From 555e15ebe8bf1eb33d00747173cfc80cc65648a4 Mon Sep 17 00:00:00 2001 From: Joshua Watt Date: Fri, 9 Feb 2018 10:27:18 -0600 Subject: Use fallthrough attribute. Use __attribute__ ((fallthrough)) to indicate switch case fall through instead of a comment. This ensures that the fallthrough warning is not triggered even if the file is pre-processed (hence stripping the comments) before it is compiled. The actual fallback implementation is hidden behind a FALLBACK macro in case the compiler doesn't support it. Finally, the -Wimplict-fallthrough warning was upgraded to only allow the attribute to satisfy it; a comment alone is no longer sufficient. Signed-off-by: Joshua Watt --- libebl/eblobjnote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libebl/eblobjnote.c') diff --git a/libebl/eblobjnote.c b/libebl/eblobjnote.c index f80a1a57..ca4f155d 100644 --- a/libebl/eblobjnote.c +++ b/libebl/eblobjnote.c @@ -223,7 +223,7 @@ ebl_object_note (Ebl *ebl, const char *name, uint32_t type, free (buf); break; } - /* FALLTHROUGH */ + FALLTHROUGH; default: /* Unknown type. */ -- cgit v1.2.3