From 24d6569408c2039a97054f3e6999cb174c076242 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Sat, 9 May 2020 05:02:25 +0200 Subject: libelf: Check for NULL shdr in elf_strptr. GCC10 -fanalyzer with -flto notices __elf64_getshdr_rdlock can fail and because the result isn't checked in elf_strptr it can cause a dereference of NULL. Signed-off-by: Mark Wielaard --- libelf/elf_strptr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libelf/elf_strptr.c') diff --git a/libelf/elf_strptr.c b/libelf/elf_strptr.c index e72a3a36..c7271707 100644 --- a/libelf/elf_strptr.c +++ b/libelf/elf_strptr.c @@ -145,7 +145,7 @@ elf_strptr (Elf *elf, size_t idx, size_t offset) else { Elf64_Shdr *shdr = strscn->shdr.e64 ?: __elf64_getshdr_rdlock (strscn); - if (unlikely (shdr->sh_type != SHT_STRTAB)) + if (unlikely (shdr == NULL || shdr->sh_type != SHT_STRTAB)) { /* This is no string section. */ __libelf_seterrno (ELF_E_INVALID_SECTION); -- cgit v1.2.3