Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6675)

Unified Diff: chrome/chrome_repack_locales.gni

Issue 1307223005: Add support for branded strings into //components/strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1310073004
Patch Set: Rebase & move IDS_ERRORPAGES_SUGGESTION_NETWORK_PREDICTION_BODY to //components/components_*_string… Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_repack_locales.gni
diff --git a/chrome/chrome_repack_locales.gni b/chrome/chrome_repack_locales.gni
index 53d57a1a961482bd3548dcfffcaa914dde2c507b..566a2da6a47e2abf3665b95337cea99619157de2 100644
--- a/chrome/chrome_repack_locales.gni
+++ b/chrome/chrome_repack_locales.gni
@@ -34,7 +34,7 @@ template("_repack_one_locale") {
"//chrome/app/resources:platform_locale_settings",
"//chrome/app:generated_resources",
"//chrome/app/resources:locale_settings",
- "//components/strings",
+ "//components/strings:components_strings",
]
if (use_ash) {
@@ -79,12 +79,23 @@ template("_repack_one_locale") {
}
if (is_chrome_branded) {
- sources +=
- [ "${root_gen_dir}/chrome/google_chrome_strings_${locale}.pak" ]
- deps += [ "//chrome/app:google_chrome_strings" ]
+ sources += [
+ "${root_gen_dir}/chrome/google_chrome_strings_${locale}.pak",
+ "${root_gen_dir}/components/strings/components_google_chrome_strings_${locale}.pak",
+ ]
+ deps += [
+ "//chrome/app:google_chrome_strings",
+ "//components/strings:components_google_chrome_strings",
+ ]
} else {
- sources += [ "${root_gen_dir}/chrome/chromium_strings_${locale}.pak" ]
- deps += [ "//chrome/app:chromium_strings" ]
+ sources += [
+ "${root_gen_dir}/chrome/chromium_strings_${locale}.pak",
+ "${root_gen_dir}/components/strings/components_chromium_strings_${locale}.pak",
+ ]
+ deps += [
+ "//chrome/app:chromium_strings",
+ "//components/strings:components_chromium_strings",
+ ]
}
output = invoker.output
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698