Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: chrome/browser/metrics/variations/ui_string_overrider_unittest.cc

Issue 1374773002: Componentize script to generate UI string overrides mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-resources-index
Patch Set: Rebase and fix //components/variations:unit_tests build with gn Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/metrics/variations/generated_resources_map.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/variations/service/ui_string_overrider.h"
6
7 #include "chrome/browser/metrics/variations/generated_resources_map.h"
8 #include "testing/gtest/include/gtest/gtest.h"
9
10 // TODO(sdefresne): componentize this tests as part of the resolution
11 // of http://crbug.com/534257 ("Decouple iOS port from using //chrome's
12 // VariationsService client").
13
14 namespace chrome_variations {
15
16 class UIStringOverriderTest : public ::testing::Test {
17 public:
18 UIStringOverriderTest()
19 : provider_(kResourceHashes, kResourceIndices, kNumResources) {}
20
21 int GetResourceIndex(uint32_t hash) {
22 return provider_.GetResourceIndex(hash);
23 }
24
25 private:
26 variations::UIStringOverrider provider_;
27
28 DISALLOW_COPY_AND_ASSIGN(UIStringOverriderTest);
29 };
30
31 TEST_F(UIStringOverriderTest, LookupNotFound) {
32 EXPECT_EQ(-1, GetResourceIndex(0));
33 EXPECT_EQ(-1, GetResourceIndex(kResourceHashes[kNumResources - 1] + 1));
34
35 // Lookup a hash that shouldn't exist.
36 // 13257681U is 1 + the hash for IDS_ZOOM_NORMAL
37 EXPECT_EQ(-1, GetResourceIndex(13257681U));
38 }
39
40 TEST_F(UIStringOverriderTest, LookupFound) {
41 for (size_t i = 0; i < kNumResources; ++i)
42 EXPECT_EQ(kResourceIndices[i], GetResourceIndex(kResourceHashes[i]));
43 }
44
45 } // namespace chrome_variations
OLDNEW
« no previous file with comments | « chrome/browser/metrics/variations/generated_resources_map.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698