Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7882)

Unified Diff: chrome/chrome_resources.gyp

Issue 1374773002: Componentize script to generate UI string overrides mapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-resources-index
Patch Set: Rebase and fix //components/variations:unit_tests build with gn Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_resources.gyp
diff --git a/chrome/chrome_resources.gyp b/chrome/chrome_resources.gyp
index 131cb137979c462daa0f626576ed89fdf0cc7280..35b3c698d1e83aba622887a6d28b689a51726d68 100644
--- a/chrome/chrome_resources.gyp
+++ b/chrome/chrome_resources.gyp
@@ -276,31 +276,49 @@
],
},
{
- # GN version: //chrome/app:make_generated_resources_map
- 'target_name': 'chrome_strings_map',
+ # GN version: //chrome/browser/metrics/variations:chrome_ui_string_overrider_factory_gen_sources
+ 'target_name': 'make_chrome_ui_string_overrider_factory',
'type': 'none',
+ 'hard_dependency': 1,
'dependencies': [ 'chrome_strings', ],
'actions': [
{
- 'action_name': 'generate_resources_map',
+ 'action_name': 'generate_ui_string_overrider',
'inputs': [
- 'browser/metrics/variations/generate_resources_map.py',
+ '../components/variations/service/generate_ui_string_overrider.py',
'<(grit_out_dir)/grit/generated_resources.h'
],
'outputs': [
- '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/generated_resources_map.cc',
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/ui_string_overrider_factory.cc',
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/ui_string_overrider_factory.h',
],
'action': [
'python',
- 'browser/metrics/variations/generate_resources_map.py',
+ '../components/variations/service/generate_ui_string_overrider.py',
+ '-N', 'chrome_variations',
+ '-o', '<(SHARED_INTERMEDIATE_DIR)',
+ '-S', 'chrome/browser/metrics/variations/ui_string_overrider_factory.cc',
+ '-H', 'chrome/browser/metrics/variations/ui_string_overrider_factory.h',
'<(grit_out_dir)/grit/generated_resources.h',
- '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/generated_resources_map.cc'
],
'message': 'Generating generated resources map.',
}
],
},
{
+ # GN version: //chrome/browser/metrics/variations:chrome_ui_string_overrider_factory
+ 'target_name': 'chrome_ui_string_overrider_factory',
+ 'type': 'static_library',
+ 'dependencies': [
+ '../components/components.gyp:variations_service',
+ 'make_chrome_ui_string_overrider_factory',
+ ],
+ 'sources': [
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/ui_string_overrider_factory.cc',
+ '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/metrics/variations/ui_string_overrider_factory.h',
+ ],
+ },
+ {
# GN version: //chrome/app/resources:platform_locale_settings
'target_name': 'platform_locale_settings',
'type': 'none',
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698