Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: components/version_info.gypi

Issue 1430393002: Specify dependencies on generate_version_info target correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/browser_sync/browser/BUILD.gn ('k') | components/version_info/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # Some plaform want to override part of the version number generation 7 # Some plaform want to override part of the version number generation
8 # (for example iOS uses a different value for PATCH level for canary). 8 # (for example iOS uses a different value for PATCH level for canary).
9 # This can be done settings "extra_version_path" variable to the path 9 # This can be done settings "extra_version_path" variable to the path
10 # of a file with the corresponding value overrides. If present it will 10 # of a file with the corresponding value overrides. If present it will
(...skipping 25 matching lines...) Expand all
36 'version_info/version_info.h', 36 'version_info/version_info.h',
37 ], 37 ],
38 'conditions': [ 38 'conditions': [
39 ['use_unofficial_version_number==1', { 39 ['use_unofficial_version_number==1', {
40 'dependencies': [ 40 'dependencies': [
41 '../ui/base/ui_base.gyp:ui_base', 41 '../ui/base/ui_base.gyp:ui_base',
42 ], 42 ],
43 'defines': ['USE_UNOFFICIAL_VERSION_NUMBER'], 43 'defines': ['USE_UNOFFICIAL_VERSION_NUMBER'],
44 }], 44 }],
45 ], 45 ],
46 'export_dependent_settings': [
47 'generate_version_info',
48 ],
49 }, 46 },
50 { 47 {
51 # GN version: //components/version_info:generate_version 48 # GN version: //components/version_info:generate_version
52 'target_name': 'generate_version_info', 49 'target_name': 'generate_version_info',
53 'type': 'none', 50 'type': 'none',
54 'direct_dependent_settings': { 51 'direct_dependent_settings': {
55 'include_dirs': [ 52 'include_dirs': [
56 '<(SHARED_INTERMEDIATE_DIR)', 53 '<(SHARED_INTERMEDIATE_DIR)',
57 ], 54 ],
58 }, 55 },
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 'variables': { 118 'variables': {
122 # Path to the file used to override the version PATH level on iOS. 119 # Path to the file used to override the version PATH level on iOS.
123 # Default to ios/build/util/VERSION. 120 # Default to ios/build/util/VERSION.
124 'ios_extra_version_path%': '../ios/build/util/VERSION', 121 'ios_extra_version_path%': '../ios/build/util/VERSION',
125 }, 122 },
126 'extra_version_name': '<(ios_extra_version_path)' 123 'extra_version_name': '<(ios_extra_version_path)'
127 }, 124 },
128 }], 125 }],
129 ], 126 ],
130 } 127 }
OLDNEW
« no previous file with comments | « components/browser_sync/browser/BUILD.gn ('k') | components/version_info/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698