Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: PRESUBMIT.py

Issue 239223005: Sync PRESUBMIT with CQ: win_x64_rel -> win_chromium_x64_rel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1321 matching lines...) Expand 10 before | Expand all | Expand 10 after
1332 'mac_chromium_rel': ['defaulttests'], 1332 'mac_chromium_rel': ['defaulttests'],
1333 'mac_nacl_sdk_build': ['compile'], 1333 'mac_nacl_sdk_build': ['compile'],
1334 'mac_rel': [ 1334 'mac_rel': [
1335 'telemetry_perf_unittests', 1335 'telemetry_perf_unittests',
1336 'telemetry_unittests', 1336 'telemetry_unittests',
1337 ], 1337 ],
1338 'win': ['compile'], 1338 'win': ['compile'],
1339 'win_chromium_compile_dbg': ['defaulttests'], 1339 'win_chromium_compile_dbg': ['defaulttests'],
1340 'win_chromium_dbg': ['defaulttests'], 1340 'win_chromium_dbg': ['defaulttests'],
1341 'win_chromium_rel': ['defaulttests'], 1341 'win_chromium_rel': ['defaulttests'],
1342 'win_chromium_x64_rel': ['defaulttests'],
1342 'win_nacl_sdk_build': ['compile'], 1343 'win_nacl_sdk_build': ['compile'],
1343 'win_rel': standard_tests + [ 1344 'win_rel': standard_tests + [
1344 'app_list_unittests', 1345 'app_list_unittests',
1345 'ash_unittests', 1346 'ash_unittests',
1346 'aura_unittests', 1347 'aura_unittests',
1347 'cc_unittests', 1348 'cc_unittests',
1348 'chrome_elf_unittests', 1349 'chrome_elf_unittests',
1349 'chromedriver_unittests', 1350 'chromedriver_unittests',
1350 'components_unittests', 1351 'components_unittests',
1351 'compositor_unittests', 1352 'compositor_unittests',
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
1446 'android_dbg', 1447 'android_dbg',
1447 'ios_dbg_simulator', 1448 'ios_dbg_simulator',
1448 'ios_rel_device', 1449 'ios_rel_device',
1449 'linux_chromium_chromeos_rel', 1450 'linux_chromium_chromeos_rel',
1450 'linux_chromium_clang_dbg', 1451 'linux_chromium_clang_dbg',
1451 'linux_chromium_rel', 1452 'linux_chromium_rel',
1452 'mac_chromium_compile_dbg', 1453 'mac_chromium_compile_dbg',
1453 'mac_chromium_rel', 1454 'mac_chromium_rel',
1454 'win_chromium_compile_dbg', 1455 'win_chromium_compile_dbg',
1455 'win_chromium_rel', 1456 'win_chromium_rel',
1456 'win_x64_rel', 1457 'win_chromium_x64_rel',
1457 ] 1458 ]
1458 1459
1459 # Match things like path/aura/file.cc and path/file_aura.cc. 1460 # Match things like path/aura/file.cc and path/file_aura.cc.
1460 # Same for chromeos. 1461 # Same for chromeos.
1461 if any(re.search('[/_](aura|chromeos)', f) for f in files): 1462 if any(re.search('[/_](aura|chromeos)', f) for f in files):
1462 builders.extend([ 1463 builders.extend([
1463 'linux_chromeos_asan', 1464 'linux_chromeos_asan',
1464 'linux_chromium_chromeos_clang_dbg' 1465 'linux_chromium_chromeos_clang_dbg'
1465 ]) 1466 ])
1466 1467
1467 # If there are gyp changes to base, build, or chromeos, run a full cros build 1468 # If there are gyp changes to base, build, or chromeos, run a full cros build
1468 # in addition to the shorter linux_chromeos build. Changes to high level gyp 1469 # in addition to the shorter linux_chromeos build. Changes to high level gyp
1469 # files have a much higher chance of breaking the cros build, which is 1470 # files have a much higher chance of breaking the cros build, which is
1470 # differnt from the linux_chromeos build that most chrome developers test 1471 # differnt from the linux_chromeos build that most chrome developers test
1471 # with. 1472 # with.
1472 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): 1473 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files):
1473 builders.extend(['cros_x86']) 1474 builders.extend(['cros_x86'])
1474 1475
1475 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1476 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1476 # unless they're .gyp(i) files as changes to those files can break the gyp 1477 # unless they're .gyp(i) files as changes to those files can break the gyp
1477 # step on that bot. 1478 # step on that bot.
1478 if (not all(re.search('^chrome', f) for f in files) or 1479 if (not all(re.search('^chrome', f) for f in files) or
1479 any(re.search('\.gypi?$', f) for f in files)): 1480 any(re.search('\.gypi?$', f) for f in files)):
1480 builders.extend(['android_aosp']) 1481 builders.extend(['android_aosp'])
1481 1482
1482 return GetDefaultTryConfigs(builders) 1483 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698