Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: chrome/browser/autofill/autofill_download.h

Issue 6931029: Set datapresent string to contain precisely those field types available in stored Autofill data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Signed and delivered Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_download.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_download.h
diff --git a/chrome/browser/autofill/autofill_download.h b/chrome/browser/autofill/autofill_download.h
index b0194955e043102c63d82e766074a6e73f06ce5c..bbbc8d16ff6add7ac3f39cab8e2310f019616b36 100644
--- a/chrome/browser/autofill/autofill_download.h
+++ b/chrome/browser/autofill/autofill_download.h
@@ -15,6 +15,7 @@
#include "base/memory/scoped_vector.h"
#include "base/time.h"
+#include "chrome/browser/autofill/autofill_type.h"
#include "chrome/common/net/url_fetcher.h"
class AutofillMetrics;
@@ -71,13 +72,16 @@ class AutofillDownloadManager : public URLFetcher::Delegate {
bool StartQueryRequest(const ScopedVector<FormStructure>& forms,
const AutofillMetrics& metric_logger);
- // Start upload request if necessary. The probability of request going
- // over the wire are GetPositiveUploadRate() if it was matched by
- // Autofill, GetNegativeUploadRate() otherwise. Observer will be called
- // even if there was no actual trip over the wire.
- // |form| - form sent in this request.
- // |form_was_matched| - true if form was matched by the Autofill.
- bool StartUploadRequest(const FormStructure& form, bool form_was_matched);
+ // Starts an upload request for the given |form|, unless throttled by the
+ // server. The probability of the request going over the wire is
+ // GetPositiveUploadRate() if |form_was_autofilled| is true, or
+ // GetNegativeUploadRate() otherwise. The observer will be called even if
+ // there was no actual trip over the wire.
+ // |available_field_types| should contain the types for which we have data
+ // stored on the local client.
+ bool StartUploadRequest(const FormStructure& form,
+ bool form_was_autofilled,
+ const FieldTypeSet& available_field_types);
// Cancels pending request.
// |form_signature| - signature of the form being cancelled. Warning:
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_download.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698