-
Notifications
You must be signed in to change notification settings - Fork 116
Closed
Description
See the detailed checklist here:
AdguardTeam/AdguardForWindows#2427
- We should use the same statuses we get from CoreLibs:
- Color indication
- Blocked - red
- Modified - yellow
- Whitelisted - green
- Bypassed - no color
- Show the full list of rules applied to the request in the log item details (including whitelist, cookie, csp, whatever).
- Additionally, show the stealth mode actions applied (if any)
- Exceptions: removed cookies and removed HTML elements should be separate items in the filtering log (just like we do now).
- "Size" value should be replaced with
↑3.0 KB ↓15.0 KB. That's important to understand what's the size of uploaded data. - Print
Connection IDfor processed requests as well - Add modify reason (see
ModifyReasonflag will be useful for this task: Update CoreLibs to 1.3.281 #2708)
Current implementation issues:
- "Removed HTML Element" events must be marked with "Blocked" status (red), not modified
- In the case of a modified cookie, you should print the original cookie instead of the URL
- ModifyReason is not handled
- Also, the change caused a new crash: https://sentry.adguard.com/adg/adguard-android-rs/issues/22619/?query=3.0.363
Reactions are currently unavailable