Greasy Fork userscripts display Error when checking for updates

[BooBerry]

AG for Windows 7.0 nightly displays Error when checking for updates for userscripts added from Greasy Fork.

Steps to reproduce

1. Find a userscript on Greasy Fork, e.g. https://greasyfork.org/en/scripts/375183-facebook-unsponsored-fixed
2. Add it to the extensions
3. Open AG for Windows, check for updates, watch the Error for the userscript.

Expected behavior

All filters/extensions/userscripts should update or display Up to date.

Actual behavior

All filters/extensions/userscripts except ones from Greasy Fork either update or display Up to date. Instead, the Greasy Fork-hosted userscript displays Error.

Screenshot:

[adbuker]

resolved in adguard-windows/pull-requests/355

[ameshkov]

@BooBerry reports in the chat that the issue still exists

There is no error now, but they aren't getting updated

[BooBerry]

It still exists in perhaps two different ways.

1. If you install a userscript and that userscript at some point gets updated by the author, the userscript isn't actually updated in AG for Windows. When I say not updated, I mean it displays the old version number (the version you initially installed) and doesn't update when there's an update.

I'm not sure if the userscript is updated and AG for Windows fails to update the version of the userscript in the UI (I need to check this if possible by installing a script, having it update, then editing the script in AG for Windows to check its version number) or if the userscript isn't updated at all. When you check for updates, the userscript shows "Up to date" when clearly this isn't the case.

2. Take a userscript like https://greasyfork.org/en/scripts/377350-hide-ads-on-facebook and try installing an older version of the userscript, e.g. https://greasyfork.org/en/scripts/377350-hide-ads-on-facebook?version=692429 and then checking for updates in AG for Windows. AG for Windows' update dialog will indeed show Error for this one. Not sure why yet.

EDIT: This second issue is likely because of the source URL used (and being used by AG for Windows to try and update it) isn't a typical URL used for userscripts.

https://greasyfork.org/scripts/377350-hide-ads-on-facebook/code/Hide%20Ads%20on%20Facebook.user.js?version=692429&d=.user.js

Which in turn displays Error when checking for updates. This is likely a different issue altogether and not related to the first issue.

[ameshkov]

Most likely the bug is caused by the absense of @updateURL and @downloadURL in greasyfork userscripts.

In this case, AG must be using the original source URL (or file path if the userscript is installed from a local file).

[BooBerry]

Okay, I just posted my own test userscript on GreasyFork and pushed a couple updates... and AG for Windows 7 updates them correctly. Odd that the other ones I used didn't update, but I'll keep watching the other userscripts I use for updates and see if they actually update and hope this was just a fluke.

[adbuker]

Most likely the bug is caused by the absense of @updateURL and @downloadURL in greasyfork userscripts.

In this case, AG must be using the original source URL (or file path if the userscript is installed from a local file).

In fact, we do so. I'll retry with the specified script again (hide-ads-on-facebook).

[adbuker]

resolved in adguard-windows/pull-requests/452/