Client API shows unnecessary fields

[sniranjank]

I updated to 106.1 today and started getting the following error while calling the client update API (/control/clients/update). Nothing else changed from my API client side. So I reverted back to 105.2 and API call works perfectly.

string(145) "failed to process request body: json: cannot unmarshal array into Go struct field clientJSON.data.whois_info of type home.RuntimeClientWhoisInfo"

[ainar-g]

Hello. The client update API—at least as documented—doesn't support the update of clients' whois_info. If that used to work, it was probably a bug, and I'm not sure if we want to make that into a feature, as whois_info is only supposed to be updated by AGH. Please make sure that your API follows the documentation.

[sniranjank]

Hmm..makes sense. Then should we need to change the /control/clients API call to not include whois_info. Right now the problem with 106.1 is that the update api does not take whois_info but the the get api gives it. 105.2 gives it as well as takes it back in the update.

[ainar-g]

Ah, I see. This seems like a bug, yes. We'll try to remove that field from that API's response.

[ainar-g]

We've pushed the fix for this issue, as well as a better documentation, to the edge channel. We plan to ship v0.106.2 today which will also include the fixes.

[sniranjank]

Awesome. You guys rock!