0755 permissions for directories, addresses #1032 #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the bug reported by @bdantas:
--appimage-extractchanges all directory permissions to700. This is unexpected and causes problems (ifsquashfs-rootis used as-is to create a new AppImage, the new AppImage must be mounted withfuseor else non-root user gets hit with "Permission denied").Desired behavior:
--appimage-extractshould not change any permissions, so that the contents ofsquashfs-rootmatch exactly what was in the original AppImage.Implemented here: Uses
0755. Implementing the desired behavior is more work, feel free to send another PR to implement it. For now, I think this already improves the situation a bit.Reference: #1032 (comment)