#3991 fix(cypher): valueType() missing NOT NULL suffix for non-null values

[robfrank]

Summary

• ValueTypeFunction.execute() now appends NOT NULL to all non-null return values, matching the Neo4j Cypher specification
• Updated 6 existing test assertions in OpenCypherMissingFunctionsTest to expect the corrected output
• Added regression test valueTypeNotNullSuffixForAllLiterals() reproducing the exact query from the issue

Closes #3991

Test plan

• OpenCypherMissingFunctionsTest#valueType* - all 7 tests pass (includes new regression)
• OpenCypherScalarFunctionsComprehensiveTest#valueType* - all 3 tests pass
• Full test run: 134 tests across both classes, 0 failures

🤖 Generated with Claude Code

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage 46.67% diff coverage

Metric	Results
Coverage variation	Report missing for 497fb7b1
Diff coverage	✅ 46.67% diff coverage

View coverage diff in Codacy

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (497fb7b)	Report Missing	Report Missing	Report Missing
Head commit (5cae2a7)	151272	99456	65.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3995)	15	7	46.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

¹ Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[gemini-code-assist]

Code Review

This pull request introduces a comprehensive system for managing Claude Code context using ArcadeDB as a graph-structured store, including detailed implementation plans and design specifications for the arcadedb-memory skill. It also modifies the ArcadeDB engine's valueType function to append a NOT NULL suffix to its output for non-null values, with corresponding test updates. Feedback points out the use of non-portable absolute paths in the documentation and identifies a recurring syntax error in the SQL DDL statements where FULL_TEXT is used instead of the correct FULLTEXT keyword.

[codecov]

Codecov Report

❌ Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.76%. Comparing base (962519d) to head (5cae2a7).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
...m/arcadedb/function/convert/ValueTypeFunction.java	40.00%	8 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3995      +/-   ##
==========================================
+ Coverage   64.19%   64.76%   +0.57%     
==========================================
  Files        1597     1597              
  Lines      120037   120033       -4     
  Branches    25554    25546       -8     
==========================================
+ Hits        77054    77736     +682     
+ Misses      32328    31535     -793     
- Partials    10655    10762     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.