Skip to content

Make sure that media resolution is only for gemini 3 model - #17137

Merged
Sameerlite merged 6 commits into
mainfrom
litellm_gemini3_media_res_fix
Dec 5, 2025
Merged

Sameerlite merged 6 commits into
mainfrom
litellm_gemini3_media_res_fix

Conversation

@Sameerlite

Copy link
Copy Markdown
Contributor

Title

Make sure that media resolution is only for gemini 3 model

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on make test-unit
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix

Changes

Made sure that media_resolution is only added in image parts if it is a gemini model

@vercel

vercel Bot commented Nov 26, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
litellm Ready Ready Preview Comment Dec 5, 2025 5:56pm

Comment thread litellm/llms/vertex_ai/gemini/transformation.py Outdated
Comment thread litellm/llms/vertex_ai/gemini/transformation.py Outdated
@Sameerlite
Sameerlite marked this pull request as draft November 27, 2025 02:54
@Sameerlite
Sameerlite marked this pull request as ready for review November 27, 2025 17:48
@Sameerlite
Sameerlite marked this pull request as draft November 27, 2025 18:00
@brano-rohlik

Copy link
Copy Markdown

hi @Sameerlite, any progress on this one?

@Sameerlite

Copy link
Copy Markdown
Contributor Author

@brano-rohlik Some internal QA are failing. I will update and merge it by tomorrow before the release.

@Sameerlite

Copy link
Copy Markdown
Contributor Author

@brano-rohlik Passing all internal QA. Merging it in

@Sameerlite
Sameerlite marked this pull request as ready for review December 5, 2025 18:36
@Sameerlite
Sameerlite merged commit e924b69 into main Dec 5, 2025
37 of 59 checks passed
@brano-rohlik

Copy link
Copy Markdown

@Sameerlite Thanks! Looking forward for the next stable releases with this fix

@ishaan-berri
ishaan-berri deleted the litellm_gemini3_media_res_fix branch March 26, 2026 21:53
fzowl pushed a commit to fzowl/litellm that referenced this pull request Jun 24, 2026
…es_fix

Make sure that media resolution is only for gemini 3 model

This branch was successfully deployed

1 active deployment
Preview — 39076678 Deployed Dec 5, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants