Repository navigation
fix: enable JSON logging via configuration and add regression test - #19037
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fzowl
pushed a commit
to fzowl/litellm
that referenced
this pull request
Jun 24, 2026
fix: enable JSON logging via configuration and add regression test
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
Fixes
json_logs: truein config file not enabling JSON logging when usingCONFIG_FILE_PATH#19036Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitCI (LiteLLM team)
Branch creation CI run
Link:
CI run for the last commit
Link:
Merge / cherry-pick CI run
Links:
Type
🐛 Bug Fix
Changes
Bug: When using
CONFIG_FILE_PATHenvironment variable (common in Helm/Kubernetes/Docker deployments), settingjson_logs: trueunderlitellm_settingsin the config YAML file does not enable JSON logging.Root cause: The CLI path (
proxy_cli.py:672-682) correctly callslitellm._turn_on_json(), but the server startup path (proxy_server.py) only sets the attribute viasetattr()without calling_turn_on_json()to reconfigure the logging handlers.Fix: Added explicit handling for
json_logsinProxyConfig.load_config()that callslitellm._turn_on_json()whenjson_logs: trueis set in the config.Test: Added
test_json_logs_calls_turn_on_json()regression test that verifies_turn_on_json()is called when loading a config withjson_logs: true.