Fixed textarea placeholder not displayed#619
Merged
Merged
Conversation
Contributor
|
Tip You can preview the changes in the Playground Plugin build for eb7fff6 is ready 🛎️!
|
There was a problem hiding this comment.
Pull request overview
Fixes a frontend regression where the placeholder text for PPOM textarea inputs was not displayed when the field appeared “empty” (due to template whitespace inside the <textarea> element).
Changes:
- Moves newline conversion (
<br />→\n) before rendering the textarea content. - Renders the textarea value inline to avoid emitting any whitespace/newlines when the value is empty (allowing the browser placeholder to show).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Soare-Robert-Daniel
approved these changes
May 26, 2026
Contributor
|
🎉 This PR is included in version 34.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed textarea placeholder is not showing when the field is empty.
Check before Pull Request is ready:
Closes #618