Repository navigation
Refactoring for new KubeHTTPClient.version() behavior - #1
Merged
Cryptophobia merged 3 commits intoAug 6, 2019
Merged
Cryptophobia merged 3 commits into
Cryptophobia merged 3 commits into
Conversation
This functionality now lives in KubeHTTPClient, so it is unnecessary to mutate the reported k8s API version in the deployment resource.
Cryptophobia
self-requested a review
August 6, 2019 12:56
Owner
|
This refactoring of the new .version() behavior is very nicely done. Also thank you for writing the new tests. @ess 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds behavior tests for KubeHTTPClient's
version()method, loosens up Deployment'sapi_versiontest to just focus on the things that it cares about, and refactors Deployment'sapi_versionmethod to use theversion()inherited from KubeHTTPClient.