Add createConnection option for http or https requests

[xv2]

issue #119

[thedillonb]

@aslakhellesoy any chance we can get this merged?

[rexxars]

Thanks for contributing!

[aslakhellesoy]

The supplied test won’t fail if createConnection isn’t called. The test just sets a boolean flag which is never checked.

The feature is undocumented. This didn’t seem quite ready to be merged. Sorry for my late review!

[rexxars]

It's checked on line 611, in the request handler - assert.ok(testResult). done() is not called apart from within that handler. Am I not reading the test correctly?

I'll add documentation for the feature unless you want this reverted.

[aslakhellesoy]

You're right @rexxars - that will teach me to stop doing code reviews on my phone :-)