Switch to classy field lenses#41
Conversation
|
The downside of this change would be more ambiguous types, since names are overloaded now. I still have to check/update the documentation and, probably, write more about lenses and shortcut @dmjio, @jkarni I would appreciate you opinion/review on this PR. Note that these changes would affect |
|
This LGTM. It seems a lot nicer to use, and at least for my purposes ambiguity isn't an issue. One thing to note is that |
- use makeFields for records - remove prefixes even for ParamSchema accessors - Swagger record field names had to gain "swagger" prefix again - also remove Paths as a redundant structure
c93d0c5 to
d70163a
Compare
|
👍 |
|
|
Closes #39.
This change affects many names and types.
The goal is to make code look nicer.
Here's one example:
These names had to gain
_suffix:type_,in_,default_(keywords);minimum_,maximum_(conflict withPrelude);enum_(conflict withControl.Lens).