tests(devtools): extend protocol timeout for load #15555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #14083
Protocol timeouts are happening a lot DT smokes for oopifs:
https://github.com/GoogleChrome/lighthouse/actions/runs/6579880151/attempts/2?pr=15554
The root cause is that Lighthouse never sees network quiet, and so Lighthouse waits for
maxWaitForLoadbefore continuing.The problem is that
oopif-requestsdefinesmaxWaitForLoadto be longer the same a the default puppeteer timeout of 180s. If Lighthouse spends 180s just waiting for load then the entire run is guaranteed to take longer than 180s. This PR extends the puppeteer timeout to 5 min to accommodate the possibility ofoopif-requestshitting it'smaxWaitForLoad.