misc: remove unneeded reportCategories from LH.ReportResult #9001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
May 20, 2019
Collaborator
patrickhulce
left a comment
There was a problem hiding this comment.
Cool beans 👍
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Util.prepareReportResultsmooshes audit results onto audit refs, but it also creates a bonus array of the report categories viaObject.values(). We barely use these and we all agree they're technical debt, so this is an easy removal.As a bonus, this PR clears up all the many places we're calling
.find()on that array to find a particular category, when the originalcategoriesis already indexed by category id :)(noticed while cleaning up
prepareReportResultin #8822, but punted until after I/O)