Skip to content

pgxnclient: fixup public libexec dir#163685

Merged
BrewTestBot merged 2 commits into
Homebrew:masterfrom
gromgit:pgxnclient/fix_libexecdir
Feb 22, 2024
Merged

pgxnclient: fixup public libexec dir#163685
BrewTestBot merged 2 commits into
Homebrew:masterfrom
gromgit:pgxnclient/fix_libexecdir

Conversation

@gromgit

@gromgit gromgit commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

Fixes #160937. Note that LIBEXECDIR is an array that already contains the private libexec dir, so this simple change should be sufficient.

@theory, please pull this PR and verify that it solves your issue.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fixes Homebrew#160937. Note that `LIBEXECDIR` is an array that already contains the private libexec dir, so this change should be sufficient.
@github-actions github-actions Bot added the python Python use is a significant feature of the PR or issue label Feb 22, 2024
@p-linnane

Copy link
Copy Markdown
Contributor

LGTM once @theory confirms. Thanks @gromgit!

@theory

theory commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

Hrm, I'm not seeing the libexec updated. I pulled your commit into /opt/homebrew/Library/Taps/homebrew/homebrew-core, uninstalled and reinstalled pgxnclient. Do I need to do something else?

I noticed it was using a bottle, so tried brew install -s pgxnclient but get the same result. I presume there's some other incantation I need to make?

@p-linnane

Copy link
Copy Markdown
Contributor

For local changes you will need to bypass our API. Try HOMEBREW_NO_INSTALL_FROM_API=1 brew install -sv pgxnclient.

@theory

theory commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

Ah, thank you! I now see:

❯ pgxn help --libexec                                       
/opt/homebrew/libexec/pgxnclient

And my libexec-aware installer now puts the app I need in the right place. SHIP IT! 🚀

@p-linnane p-linnane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to hear it. Thanks again @gromgit!

@github-actions

Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 22, 2024
Merged via the queue into Homebrew:master with commit 65c1d71 Feb 22, 2024
@github-actions github-actions Bot added the outdated PR was locked due to age label Mar 24, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 24, 2024
@gromgit gromgit deleted the pgxnclient/fix_libexecdir branch February 21, 2025 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pgxnclient Needs LIBEXEC set

4 participants