pgxnclient: fixup public libexec dir#163685
Merged
Merged
Conversation
Fixes Homebrew#160937. Note that `LIBEXECDIR` is an array that already contains the private libexec dir, so this change should be sufficient.
Contributor
Contributor
|
Hrm, I'm not seeing the libexec updated. I pulled your commit into I noticed it was using a bottle, so tried |
Contributor
|
For local changes you will need to bypass our API. Try |
Contributor
|
Ah, thank you! I now see: ❯ pgxn help --libexec
/opt/homebrew/libexec/pgxnclientAnd my libexec-aware installer now puts the app I need in the right place. SHIP IT! 🚀 |
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160937. Note that
LIBEXECDIRis an array that already contains the private libexec dir, so this simple change should be sufficient.@theory, please pull this PR and verify that it solves your issue.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?