Skip to content

fix: table name case sensitivity in join and pattern statement#1314

Merged
Yangyang96 merged 2 commits into
KusionStack:mainfrom
liu-hm19:fix-table-name-case
Nov 13, 2024
Merged

fix: table name case sensitivity in join and pattern statement#1314
Yangyang96 merged 2 commits into
KusionStack:mainfrom
liu-hm19:fix-table-name-case

Conversation

@liu-hm19

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes the issues of the table name case sensitivity in JOIN and pattern statement.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/bug Something isn't working label Nov 13, 2024
@liu-hm19 liu-hm19 requested a review from ffforest November 13, 2024 07:59
@liu-hm19 liu-hm19 self-assigned this Nov 13, 2024
@liu-hm19 liu-hm19 requested a review from Yangyang96 November 13, 2024 08:00
Yangyang96
Yangyang96 previously approved these changes Nov 13, 2024

@Yangyang96 Yangyang96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@ffforest ffforest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 11813185658

Details

  • 10 of 17 (58.82%) changed or added relevant lines in 4 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 49.555%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/infra/persistence/util.go 2 4 50.0%
pkg/infra/persistence/run.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/operation/parser/parser.go 6 75.61%
Totals Coverage Status
Change from base Build 11812336773: -0.02%
Covered Lines: 10519
Relevant Lines: 21227

💛 - Coveralls

@Yangyang96 Yangyang96 merged commit 210ef29 into KusionStack:main Nov 13, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2024
@ffforest ffforest added this to the v0.14.0 milestone Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants