Skip to content

bar plot value labels are wrong when yOffset is used #584

Closed

Description

@swharden

Thank you Terbaco for mentioning this over email.

This bug should be fixed, but also it would be nice if users could provide an array of manual plot value labels. Perhaps if this array is null the values will be used, but if it is not the labels will be used.

image

Activity

  1. bclehmann commented on Oct 18, 2020

    @bclehmann
    Member

    Interesting, this one isn't "wrong" so much as it's the wrong choice for the default. For example, this could be a worthwhile addition (excuse the poor photoshop, even by my standards):

    image

    I could see this being useful for waterfall plots especially, which were added in June #476, however, the default certainly should be to show the value, not the growth/loss.

  2. added a commit that references this issue on Nov 25, 2020
  3. swharden commented on Nov 25, 2020

    @swharden
    MemberAuthor

    Probably the best long-term solution would be to let the user define what the labels by passing in a string[]... I'll add it to #412

    For now I changed the default behavior based on the principle of least astonishment which I think is good enough to mark this issue resolved 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions