Skip to content

fix: add more detailed error messages#1665

Merged
johnnyreilly merged 2 commits into
TypeStrong:mainfrom
hai-x:more-error-msg
Jan 11, 2025
Merged

fix: add more detailed error messages#1665
johnnyreilly merged 2 commits into
TypeStrong:mainfrom
hai-x:more-error-msg

Conversation

@hai-x

@hai-x hai-x commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

Small change and make error messages more detailed.

image

@johnnyreilly

Copy link
Copy Markdown
Member

Thanks - I think if I understand it correctly, you want to alter the error message? Could you adjust the PR so it only does that please?

Comment thread src/servicesHost.ts
}
return result;
}
``;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small fix.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@hai-x

hai-x commented Jan 11, 2025

Copy link
Copy Markdown
Contributor Author

Thanks - I think if I understand it correctly, you want to alter the error message? Could you adjust the PR so it only does that please?

Ajusted. Could you please review it again?

@johnnyreilly

Copy link
Copy Markdown
Member

Let's get the GitHub actions running....

@johnnyreilly

Copy link
Copy Markdown
Member

Please could you update the version in the package.json (patch increment) and put an entry in the CHANGE LOG.md too?

@johnnyreilly

Copy link
Copy Markdown
Member

You are using thread-loader I'm guessing? What's the motivation?

@hai-x

hai-x commented Jan 11, 2025

Copy link
Copy Markdown
Contributor Author

Please could you update the version in the package.json (patch increment) and put an entry in the CHANGE LOG.md too?

Sure.

@hai-x

hai-x commented Jan 11, 2025

Copy link
Copy Markdown
Contributor Author

You are using thread-loader I'm guessing? What's the motivation?

Leverage the power of multi-core in our building system.

@hai-x

hai-x commented Jan 11, 2025

Copy link
Copy Markdown
Contributor Author

Please could you update the version in the package.json (patch increment) and put an entry in the CHANGE LOG.md too?

Done.

@johnnyreilly
johnnyreilly merged commit e652315 into TypeStrong:main Jan 11, 2025
@johnnyreilly

Copy link
Copy Markdown
Member

@johnnyreilly

Copy link
Copy Markdown
Member

Looks like there's a small issue with the release pipeline. Will have to fix that before I can ship the change

@hai-x

hai-x commented Jan 11, 2025

Copy link
Copy Markdown
Contributor Author

Looks like there's a small issue with the release pipeline. Will have to fix that before I can ship the change

Yes. It seems to be caused by conflict between pnpm version and node version.

@hai-x

hai-x commented Jan 11, 2025

Copy link
Copy Markdown
Contributor Author

Looks like there's a small issue with the release pipeline. Will have to fix that before I can ship the change

Yes. It seems to be caused by conflict between pnpm version and node version.

I have seen that you have open a related PR. https://github.com/TypeStrong/ts-loader/pull/1666/files

@johnnyreilly

Copy link
Copy Markdown
Member

Hopefully this will do it: https://github.com/TypeStrong/ts-loader/actions/runs/12726168149/job/35474238704

Will fix up version numbers later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants