Skip to content

Just tinkering to see if the font library modal could be extracted to a package and then loaded in the wp-admin interface.#58338

Closed
pbking wants to merge 1 commit into
trunkfrom
try/refactor-font-library-ui-to-package-and-wp-admin
Closed

Just tinkering to see if the font library modal could be extracted to a package and then loaded in the wp-admin interface.#58338
pbking wants to merge 1 commit into
trunkfrom
try/refactor-font-library-ui-to-package-and-wp-admin

Conversation

@pbking

@pbking pbking commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

… a package and then loaded in the wp-admin interface.
@pbking pbking requested a review from spacedmonkey as a code owner January 26, 2024 21:39
@pbking pbking marked this pull request as draft January 26, 2024 21:39
@github-actions

Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions

Copy link
Copy Markdown

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/font-library-admin.php
❔ lib/load.php

@Mamaduka

Copy link
Copy Markdown
Member

@pbking, can we close this PR?

@pbking pbking closed this Jun 4, 2025
@Mamaduka Mamaduka deleted the try/refactor-font-library-ui-to-package-and-wp-admin branch June 4, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants