Merge Flutter client from original repo...#284
Conversation
…/merge-flutter-who
|
| title: S.of(context).shareTheApp, | ||
| lightColor: true, | ||
| onPressed: () => Share.share( | ||
| 'Check out the official COVID-19 GUIDE App https://preview.whoapp.org/menu')), |
There was a problem hiding this comment.
Not blocking check-in this has to go away
There was a problem hiding this comment.
hm. easily changed if you have a suggestion for tonight...
There was a problem hiding this comment.
That URL would be a url to the app itself on the appropriate app store.
We have no idea what the bundle id is for Apple yet for example.
| @@ -0,0 +1,37 @@ | |||
| # Miscellaneous | |||
There was a problem hiding this comment.
Merge in to the top level .gitignore. It's already duplicative in places and a second file isn't needed:
https://stackoverflow.com/a/3307252
| @@ -0,0 +1,16 @@ | |||
| # WHOFlutter | |||
There was a problem hiding this comment.
add spacing:
| # WHOFlutter | |
| # WHO Flutter App |
| - [Lab: Write your first Flutter app](https://flutter.dev/docs/get-started/codelab) | ||
| - [Cookbook: Useful Flutter samples](https://flutter.dev/docs/cookbook) | ||
|
|
||
| For help getting started with Flutter, view our |
| @@ -0,0 +1,7 @@ | |||
| gradle-wrapper.jar | |||
There was a problem hiding this comment.
merge in to top level .gitignore
| @@ -0,0 +1,7 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
a much better list of permissions:
👍
| @@ -0,0 +1,12 @@ | |||
| package com.example.WHOFlutter | |||
There was a problem hiding this comment.
should we have the Kotlin example in here? I'd worry about someone trying to build it out when we want the energy focused on the Flutter code
There was a problem hiding this comment.
So this automatically generated hook is where the Flutter plugins register their native components. More generally this is the place where we might end up adding a small amount of native code in the future if needed.
There was a problem hiding this comment.
Ah, I see the com.example domain was mistakenly left in there making it appear that this is example code. I will fix.
| <?xml version="1.0" encoding="utf-8"?> | ||
| <resources> | ||
| <color name="ic_launcher_background">#3A8CC4</color> | ||
| </resources> No newline at end of file |
There was a problem hiding this comment.
missing trailing newline
| @@ -0,0 +1,31 @@ | |||
| buildscript { | |||
| @@ -0,0 +1,32 @@ | |||
| *.mode1v3 | |||
There was a problem hiding this comment.
this is the first .gitignore that seems like it could justify a second directory specific file.... certainly there's some duplication that can be removed, e.g. DerivedData and see here:
https://github.com/WorldHealthOrganization/app/blob/master/.gitignore#L29
| @@ -0,0 +1,21 @@ | |||
| { | |||
There was a problem hiding this comment.
splash-2732x2732.imageset/Contents.json
... that's a big splash screen
What does this PR accomplish?
Did you add any dependencies?
How did you test the change?