fix(column-resize): Resize table as well as columns, improve handing … (#19264)

Author: kseamon

src/cdk-experimental/column-resize/column-resize-directives/column-resize-flex.ts

@@ -27,7 +27,7 @@ import {FLEX_PROVIDERS} from './constants';
 export class CdkColumnResizeFlex extends ColumnResize {
   constructor(
       readonly columnResizeNotifier: ColumnResizeNotifier,
-      protected readonly elementRef: ElementRef,
+      readonly elementRef: ElementRef<HTMLElement>,
       protected readonly eventDispatcher: HeaderRowEventDispatcher,
       protected readonly ngZone: NgZone,
       protected readonly notifier: ColumnResizeNotifierSource) {

src/cdk-experimental/column-resize/column-resize-directives/column-resize.ts

@@ -27,7 +27,7 @@ import {TABLE_PROVIDERS} from './constants';
 export class CdkColumnResize extends ColumnResize {
   constructor(
       readonly columnResizeNotifier: ColumnResizeNotifier,
-      protected readonly elementRef: ElementRef,
+      readonly elementRef: ElementRef<HTMLElement>,
       protected readonly eventDispatcher: HeaderRowEventDispatcher,
       protected readonly ngZone: NgZone,
       protected readonly notifier: ColumnResizeNotifierSource) {

src/cdk-experimental/column-resize/column-resize-directives/default-enabled-column-resize-flex.ts

@@ -27,7 +27,7 @@ import {FLEX_PROVIDERS} from './constants';
 export class CdkDefaultEnabledColumnResizeFlex extends ColumnResize {
   constructor(
       readonly columnResizeNotifier: ColumnResizeNotifier,
-      protected readonly elementRef: ElementRef,
+      readonly elementRef: ElementRef<HTMLElement>,
       protected readonly eventDispatcher: HeaderRowEventDispatcher,
       protected readonly ngZone: NgZone,
       protected readonly notifier: ColumnResizeNotifierSource) {

src/cdk-experimental/column-resize/column-resize-directives/default-enabled-column-resize.ts

@@ -27,7 +27,7 @@ import {TABLE_PROVIDERS} from './constants';
 export class CdkDefaultEnabledColumnResize extends ColumnResize {
   constructor(
       readonly columnResizeNotifier: ColumnResizeNotifier,
-      protected readonly elementRef: ElementRef,
+      readonly elementRef: ElementRef<HTMLElement>,
       protected readonly eventDispatcher: HeaderRowEventDispatcher,
       protected readonly ngZone: NgZone,
       protected readonly notifier: ColumnResizeNotifierSource) {

src/cdk-experimental/column-resize/column-resize-notifier.ts

@@ -16,6 +16,9 @@ export interface ColumnSize {
 
   /** The width in pixels of the column. */
   readonly size: number;
+
+  /** The width in pixels of the column prior to this update, if known. */
+  readonly previousSize?: number;
 }
 
 /** Interface describing column size changes. */
@@ -28,7 +31,10 @@ export interface ColumnSizeAction extends ColumnSize {
   readonly completeImmediately?: boolean;
 }
 
-/** Originating source of column resize events within a table. */
+/**
+ * Originating source of column resize events within a table.
+ * @docs-private
+ */
 @Injectable()
 export class ColumnResizeNotifierSource {
   /** Emits when an in-progress resize is canceled. */

src/cdk-experimental/column-resize/column-resize.ts

@@ -32,7 +32,9 @@ export abstract class ColumnResize implements AfterViewInit, OnDestroy {
   /* Publicly accessible interface for triggering and being notified of resizes. */
   abstract readonly columnResizeNotifier: ColumnResizeNotifier;
 
-  protected abstract readonly elementRef: ElementRef<HTMLElement>;
+  /* ElementRef that this directive is attached to. Exposed For use by column-level directives */
+  abstract readonly elementRef: ElementRef<HTMLElement>;
+
   protected abstract readonly eventDispatcher: HeaderRowEventDispatcher;
   protected abstract readonly ngZone: NgZone;
   protected abstract readonly notifier: ColumnResizeNotifierSource;
@@ -61,6 +63,11 @@ export abstract class ColumnResize implements AfterViewInit, OnDestroy {
     return `cdk-column-resize-${this.selectorId}`;
   }
 
+  /** Called when a column in the table is resized. Applies a css class to the table element. */
+  setResized() {
+    this.elementRef.nativeElement!.classList.add(WITH_RESIZED_COLUMN_CLASS);
+  }
+
   private _listenForRowHoverEvents() {
     this.ngZone.runOutsideAngular(() => {
       const element = this.elementRef.nativeElement!;
@@ -87,7 +94,7 @@ export abstract class ColumnResize implements AfterViewInit, OnDestroy {
         takeUntil(this.destroyed),
         take(1),
     ).subscribe(() => {
-      this.elementRef.nativeElement!.classList.add(WITH_RESIZED_COLUMN_CLASS);
+      this.setResized();
     });
   }
 

src/cdk-experimental/column-resize/overlay-handle.ts

@@ -92,9 +92,8 @@ export abstract class ResizeOverlayHandle implements AfterViewInit, OnDestroy {
 
     const startX = mousedownEvent.screenX;
 
-    const initialOverlayOffset = this._getOverlayOffset();
     const initialSize = this._getOriginWidth();
-    let overlayOffset = initialOverlayOffset;
+    let overlayOffset = this._getOverlayOffset();
     let originOffset = this._getOriginOffset();
     let size = initialSize;
     let overshot = 0;
@@ -143,7 +142,7 @@ export abstract class ResizeOverlayHandle implements AfterViewInit, OnDestroy {
           Math.max(computedNewSize, this.resizeRef.minWidthPx, 0), this.resizeRef.maxWidthPx);
 
       this.resizeNotifier.triggerResize.next(
-          {columnId: this.columnDef.name, size: computedNewSize});
+          {columnId: this.columnDef.name, size: computedNewSize, previousSize: size});
 
       const originNewSize = this._getOriginWidth();
       const originNewOffset = this._getOriginOffset();
@@ -153,7 +152,7 @@ export abstract class ResizeOverlayHandle implements AfterViewInit, OnDestroy {
       originOffset = originNewOffset;
 
       overshot += deltaX + (this._isLtr() ? -originSizeDeltaX : originSizeDeltaX);
-      overlayOffset += originSizeDeltaX + originOffsetDeltaX;
+      overlayOffset += originOffsetDeltaX + (this._isLtr() ? originSizeDeltaX : 0);
 
       this._updateOverlayOffset(overlayOffset);
     });
@@ -169,29 +168,15 @@ export abstract class ResizeOverlayHandle implements AfterViewInit, OnDestroy {
   }
 
   private _getOriginOffset(): number {
-    const originElement = this.resizeRef.origin.nativeElement!;
-    const offsetLeft = originElement.offsetLeft;
-
-    return this._isLtr() ?
-        offsetLeft :
-        originElement.offsetParent!.offsetWidth - (offsetLeft + this._getOriginWidth());
+    return this.resizeRef.origin.nativeElement!.offsetLeft;
   }
 
   private _getOverlayOffset(): number {
-    const overlayElement = this.resizeRef.overlayRef.overlayElement;
-    return this._isLtr() ?
-        parseInt(overlayElement.style.left!, 10) : parseInt(overlayElement.style.right!, 10);
+    return parseInt(this.resizeRef.overlayRef.overlayElement.style.left!, 10);
   }
 
   private _updateOverlayOffset(offset: number): void {
-    const overlayElement = this.resizeRef.overlayRef.overlayElement;
-    const overlayOffsetCssValue = coerceCssPixelValue(offset);
-
-    if (this._isLtr()) {
-      overlayElement.style.left = overlayOffsetCssValue;
-    } else {
-      overlayElement.style.right = overlayOffsetCssValue;
-    }
+    this.resizeRef.overlayRef.overlayElement.style.left = coerceCssPixelValue(offset);
   }
 
   private _isLtr(): boolean {

src/cdk-experimental/column-resize/resizable.ts

@@ -70,6 +70,7 @@ export abstract class Resizable<HandleComponent extends ResizeOverlayHandle>
     this.minWidthPxInternal = value;
 
     if (this.elementRef.nativeElement) {
+      this.columnResize.setResized();
       this._applyMinWidthPx();
     }
   }
@@ -82,6 +83,7 @@ export abstract class Resizable<HandleComponent extends ResizeOverlayHandle>
     this.maxWidthPxInternal = value;
 
     if (this.elementRef.nativeElement) {
+      this.columnResize.setResized();
       this._applyMaxWidthPx();
     }
   }
@@ -116,20 +118,23 @@ export abstract class Resizable<HandleComponent extends ResizeOverlayHandle>
     // of two table cells and is also useful for displaying a resize thumb
     // over both cells and extending it down the table as needed.
 
+    const isRtl = this.directionality.value === 'rtl';
     const positionStrategy = this.overlay.position()
         .flexibleConnectedTo(this.elementRef.nativeElement!)
         .withFlexibleDimensions(false)
         .withGrowAfterOpen(false)
         .withPush(false)
+        .withDefaultOffsetX(isRtl ? 1 : 0)
         .withPositions([{
-          originX: 'end',
+          originX: isRtl ? 'start' : 'end',
           originY: 'top',
           overlayX: 'center',
           overlayY: 'top',
         }]);
 
     return this.overlay.create({
-      direction: this.directionality,
+      // Always position the overlay based on left-indexed coordinates.
+      direction: 'ltr',
       disposeOnNavigation: true,
       positionStrategy,
       scrollStrategy: this.overlay.scrollStrategies.reposition(),
@@ -166,9 +171,9 @@ export abstract class Resizable<HandleComponent extends ResizeOverlayHandle>
     ).pipe(
         takeUntilDestroyed,
         filter(columnSize => columnSize.columnId === this.columnDef.name),
-    ).subscribe(({size, completeImmediately}) => {
+    ).subscribe(({size, previousSize, completeImmediately}) => {
       this.elementRef.nativeElement!.classList.add(OVERLAY_ACTIVE_CLASS);
-      this._applySize(size);
+      this._applySize(size, previousSize);
 
       if (completeImmediately) {
         this._completeResizeOperation();
@@ -223,11 +228,11 @@ export abstract class Resizable<HandleComponent extends ResizeOverlayHandle>
     this.overlayRef!.updateSize({height: this.elementRef.nativeElement!.offsetHeight});
   }
 
-  private _applySize(sizeInPixels: number): void {
+  private _applySize(sizeInPixels: number, previousSize?: number): void {
     const sizeToApply = Math.min(Math.max(sizeInPixels, this.minWidthPx, 0), this.maxWidthPx);
 
     this.resizeStrategy.applyColumnSize(this.columnDef.cssClassFriendlyName,
-        this.elementRef.nativeElement!, sizeToApply);
+        this.elementRef.nativeElement!, sizeToApply, previousSize);
   }
 
   private _applyMinWidthPx(): void {

src/cdk-experimental/column-resize/resize-strategy.ts

@@ -18,20 +18,34 @@ import {ColumnResize} from './column-resize';
  */
 @Injectable()
 export abstract class ResizeStrategy {
+  protected abstract readonly columnResize: ColumnResize;
+
+  /** Updates the width of the specified column. */
   abstract applyColumnSize(
       cssFriendlyColumnName: string,
       columnHeader: HTMLElement,
-      sizeInPx: number): void;
+      sizeInPx: number,
+      previousSizeInPx?: number): void;
 
+  /** Applies a minimum width to the specified column, updating its current width as needed. */
   abstract applyMinColumnSize(
       cssFriendlyColumnName: string,
       columnHeader: HTMLElement,
       minSizeInPx: number): void;
 
+  /** Applies a maximum width to the specified column, updating its current width as needed. */
   abstract applyMaxColumnSize(
       cssFriendlyColumnName: string,
       columnHeader: HTMLElement,
       minSizeInPx: number): void;
+
+  /** Adjusts the width of the table element by the specified delta. */
+  protected updateTableWidth(delta: number): void {
+    const table = this.columnResize.elementRef.nativeElement;
+    const tableWidth = getElementWidth(table);
+
+    table.style.width = coerceCssPixelValue(tableWidth + delta);
+  }
 }
 
 /**
@@ -43,17 +57,31 @@ export abstract class ResizeStrategy {
  */
 @Injectable()
 export class TableLayoutFixedResizeStrategy extends ResizeStrategy {
-  applyColumnSize(_: string, columnHeader: HTMLElement, sizeInPx: number): void {
+  constructor(protected readonly columnResize: ColumnResize) {
+    super();
+  }
+
+  applyColumnSize(_: string, columnHeader: HTMLElement, sizeInPx: number,
+      previousSizeInPx?: number): void {
+    const delta = sizeInPx - (previousSizeInPx ?? getElementWidth(columnHeader));
+
     columnHeader.style.width = coerceCssPixelValue(sizeInPx);
+
+    this.updateTableWidth(delta);
   }
 
   applyMinColumnSize(_: string, columnHeader: HTMLElement, sizeInPx: number): void {
-    columnHeader.style.minWidth = coerceCssPixelValue(sizeInPx);
+    const currentWidth = getElementWidth(columnHeader);
+    const newWidth = Math.max(currentWidth, sizeInPx);
+
+    this.applyColumnSize(_, columnHeader, newWidth, currentWidth);
   }
 
-  applyMaxColumnSize(): void {
-    // Intentionally omitted as max-width causes strange rendering issues in Chrome.
-    // Max size will still apply when the user is resizing this column.
+  applyMaxColumnSize(_: string, columnHeader: HTMLElement, sizeInPx: number): void {
+    const currentWidth = getElementWidth(columnHeader);
+    const newWidth = Math.min(currentWidth, sizeInPx);
+
+    this.applyColumnSize(_, columnHeader, newWidth, currentWidth);
   }
 }
 
@@ -76,16 +104,23 @@ export class CdkFlexTableResizeStrategy extends ResizeStrategy implements OnDest
   protected readonly defaultMaxSize = Number.MAX_SAFE_INTEGER;
 
   constructor(
-      private readonly _columnResize: ColumnResize,
+      protected readonly columnResize: ColumnResize,
       @Inject(DOCUMENT) document: any) {
     super();
     this._document = document;
   }
 
-  applyColumnSize(cssFriendlyColumnName: string, _: HTMLElement, sizeInPx: number): void {
+  applyColumnSize(cssFriendlyColumnName: string, columnHeader: HTMLElement,
+      sizeInPx: number, previousSizeInPx?: number): void {
+    // Optimization: Check applied width first as we probably set it already before reading
+    // offsetWidth which triggers layout.
+    const delta = sizeInPx - (previousSizeInPx ??
+        (this._getAppliedWidth(cssFriendlyColumnName) || columnHeader.offsetWidth));
+
     const cssSize = coerceCssPixelValue(sizeInPx);
 
     this._applyProperty(cssFriendlyColumnName, 'flex', `0 0.01 ${cssSize}`);
+    this.updateTableWidth(delta);
   }
 
   applyMinColumnSize(cssFriendlyColumnName: string, _: HTMLElement, sizeInPx: number): void {
@@ -106,14 +141,23 @@ export class CdkFlexTableResizeStrategy extends ResizeStrategy implements OnDest
     return `cdk-column-${cssFriendlyColumnName}`;
   }
 
-  ngOnDestroy() {
+  ngOnDestroy(): void {
     // TODO: Use remove() once we're off IE11.
     if (this._styleElement && this._styleElement.parentNode) {
       this._styleElement.parentNode.removeChild(this._styleElement);
       this._styleElement = undefined;
     }
   }
 
+  private _getPropertyValue(cssFriendlyColumnName: string, key: string): string|undefined {
+    const properties = this._getColumnPropertiesMap(cssFriendlyColumnName);
+    return properties.get(key);
+  }
+
+  private _getAppliedWidth(cssFriendslyColumnName: string): number {
+    return coercePixelsFromFlexValue(this._getPropertyValue(cssFriendslyColumnName, 'flex'));
+  }
+
   private _applyProperty(
       cssFriendlyColumnName: string,
       key: string,
@@ -166,7 +210,7 @@ export class CdkFlexTableResizeStrategy extends ResizeStrategy implements OnDest
     }
 
     const columnClassName = this.getColumnCssClass(cssFriendlyColumnName);
-    const tableClassName = this._columnResize.getUniqueCssClass();
+    const tableClassName = this.columnResize.getUniqueCssClass();
 
     const selector = `.${tableClassName} .${columnClassName}`;
     const body = propertyKeys.map(key => `${key}:${properties.get(key)}`).join(';');
@@ -175,6 +219,26 @@ export class CdkFlexTableResizeStrategy extends ResizeStrategy implements OnDest
   }
 }
 
+/** Converts CSS pixel values to numbers, eg "123px" to 123. Returns NaN for non pixel values. */
+function coercePixelsFromCssValue(cssValue: string): number {
+  return Number(cssValue.match(/(\d+)px/)?.[1]);
+}
+
+/** Gets the style.width pixels on the specified element if present, otherwise its offsetWidth. */
+function getElementWidth(element: HTMLElement) {
+  // Optimization: Check style.width first as we probably set it already before reading
+  // offsetWidth which triggers layout.
+  return coercePixelsFromCssValue(element.style.width) || element.offsetWidth;
+}
+
+/**
+ * Converts CSS flex values as set in CdkFlexTableResizeStrategy to numbers,
+ * eg "0 0.01 123px" to 123.
+ */
+function coercePixelsFromFlexValue(flexValue: string|undefined): number {
+  return Number(flexValue?.match(/0 0\.01 (\d+)px/)?.[1]);
+}
+
 export const TABLE_LAYOUT_FIXED_RESIZE_STRATEGY_PROVIDER: Provider = {
   provide: ResizeStrategy,
   useClass: TableLayoutFixedResizeStrategy,

src/components-examples/material-experimental/column-resize/default-enabled-flex/default-enabled-column-resize-flex-demo.css

@@ -0,0 +1,4 @@
+:host {
+  display: block;
+  overflow: auto;
+}