Remove duplicate check (#1740) (#1834)

jrgemignani · jberzy · web-flow · commit 29a352f50248 · 2024-05-03T15:40:13.000-07:00
This commit removes [a benign] redundant check for label validity

Co-authored-by: jberzy &lt;john.berzy@gmail.com&gt;
diff --git a/src/backend/commands/label_commands.c b/src/backend/commands/label_commands.c
@@ -279,12 +279,6 @@ void create_label(char *graph_name, char *label_name, char label_type,
                         errmsg("label name is invalid")));
     }
 
-    if (!is_valid_label(label_name, label_type))
-    {
-        ereport(ERROR, (errcode(ERRCODE_UNDEFINED_SCHEMA),
-                        errmsg("label name is invalid")));
-    }
-
     cache_data = search_graph_name_cache(graph_name);
     if (!cache_data)
     {

Original file line number	Diff line number	Diff line change
`@@ -279,12 +279,6 @@ void create_label(char graph_name, char label_name, char label_type,`
`279`	`279`	`errmsg("label name is invalid")));`
`280`	`280`	`}`
`281`	`281`
`282`		`- if (!is_valid_label(label_name, label_type))`
`283`		`- {`
`284`		`- ereport(ERROR, (errcode(ERRCODE_UNDEFINED_SCHEMA),`
`285`		`- errmsg("label name is invalid")));`
`286`		`- }`
`287`		`-`
`288`	`282`	`cache_data = search_graph_name_cache(graph_name);`
`289`	`283`	`if (!cache_data)`
`290`	`284`	`{`