[SUREFIRE-2221] Document minimum supported Java version for Toolchains#701
Merged
Conversation
Contributor
Author
|
I hope I've understood the syntax of the documentation correctly. Note that I didn't check if this generates the web site properly. Also I tried to search minimal java version requirement for older surefire version. I think this would be a useful information but didn't find any easy way to get that. |
michael-o
requested changes
Dec 13, 2023
michael-o
requested changes
Dec 13, 2023
michael-o
approved these changes
Dec 13, 2023
Member
michael-o
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Looks good to me now. Will handle squash and merge.
Contributor
Author
Thx 🙏 for taking time to answer to questions and maintaining this useful piece of software. (Keep in mind that I didn't test if this will generate web site correctly) |
|
Resolve #2748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was triggered by https://issues.apache.org/jira/browse/SUREFIRE-1923?focusedCommentId=17795866&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17795866