I have done the following
Steps to reproduce
Our plumbing for these VZ device attachments options is broken, which means that we're using the default values.
For container we want to default to the safest sync option and allow the user to opt into higher performance but less safe options.
Current behavior
ContainerClient defaults for Filesystem are the following, but auto/full aren't being set in the SandboxService.
/// A block based filesystem.
public static func block(
format: String, source: String, destination: String, options: MountOptions, cache: CacheMode = .auto,
sync: SyncMode = .full
) -> Filesystem {
.init(
type: .block(format: format, cache: cache, sync: sync),
source: URL(fileURLWithPath: source).absolutePath(),
destination: destination,
options: options
)
}
/// A named volume filesystem.
public static func volume(
name: String, format: String, source: String, destination: String, options: MountOptions,
cache: CacheMode = .auto, sync: SyncMode = .full
) -> Filesystem {
.init(
type: .volume(name: name, format: format, cache: cache, sync: sync),
source: URL(fileURLWithPath: source).absolutePath(),
destination: destination,
options: options
)
}
Expected behavior
SandboxService should translate the cache and sync properties on the parameters to the runtimeOptions on containerization Mount.
Environment
- OS:
- Xcode:
- Container:
Relevant log output
Code of Conduct
I have done the following
Steps to reproduce
Our plumbing for these VZ device attachments options is broken, which means that we're using the default values.
For container we want to default to the safest sync option and allow the user to opt into higher performance but less safe options.
Current behavior
ContainerClient defaults for Filesystem are the following, but auto/full aren't being set in the SandboxService.
Expected behavior
SandboxService should translate the cache and sync properties on the parameters to the runtimeOptions on containerization Mount.
Environment
Relevant log output
Code of Conduct