Add proxy to backup agent via global var(release-7.1)#10875
Conversation
| Future<bool> doTask(Database cx, | ||
| Reference<FutureBucket> futureBucket, | ||
| Reference<Task> task, | ||
| Optional<std::string> proxy); |
There was a problem hiding this comment.
Adding an parameter for TaskBucket is awkward, because it's a setting unrelated to the abstraction.
A better (still not ideal) way may be just declare a global variable for FileBackupAgent to use, which can be set by the backup agent.
There was a problem hiding this comment.
thanks, yeah this PR is just for demo purpose and is not ready yet, but the advise makes sense
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
| Reference<IBackupContainer> _bc = wait(config.backupContainer().getOrThrow(tr)); | ||
| bc = fileBackup::getBackupContainerWithProxy(_bc); |
There was a problem hiding this comment.
The original wait waits for 2 things together, which is more efficient and preferred. Instead of wait here, i think you can just add bc = fileBackup::getBackupContainerWithProxy(bc); with the original wait above.
There was a problem hiding this comment.
I add another var just in case there is surprise from flow, i can change it to the way you described as well, let me know
| wait(store(latestRestorableVersion, config.getLatestRestorableVersion(tr))); | ||
| Reference<IBackupContainer> _bc = wait(config.backupContainer().getOrThrow(tr)); | ||
| bc = fileBackup::getBackupContainerWithProxy(_bc); | ||
| wait(store(recentReadVersion, tr->getReadVersion())); |
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
johscheuer
left a comment
There was a problem hiding this comment.
I did a test and using the HTTP_PROXY env variable worked.
Could we add the OPT_PROXY to the backup_agent args:
foundationdb/fdbbackup/backup.actor.cpp
Lines 211 to 239 in d47e0ea
--proxy.
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
backup agent itself does not have proxy info. This changes adds the proxy via a global var.
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
backport #10885
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)