Use the js-jquery and js-flot libraries rather than copying all the source#72
Merged
Conversation
Closed
Member
|
@RyanGlScott looked this over and agrees with it. |
Member
|
Curious -- it looks like accidentally closing and reopening gives travis a kick to get going. |
Member
|
Yep, I'd consider that a feature. Sometimes, a Travis CI build fails because you didn't wait long enough to wait for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Criterion uses the Flot and jQuery Javascript libraries. At the moment, it keeps copies locally and also has copies of the source code to be compliant with Debian conditions. It doesn't actually ship the licenses for those libraries, so it might not technically be in compliance even now.
This patch switches to the js-jquery and js-flot libraries on Hackage, which are dead simple, and just contain the jquery/flot code, including license and sources to make Debian happy. The Shake library already uses them, and I'm hoping to make them the "standard" way of getting this code.
As a side effect, I've also switched to the 1.* branch of jQuery rather than 2.. The 2. branch has no additional features or performance, but has worse compatibility, so currently 1.* is recommended. If that's a conscious decision, I'm happy to build a version of the js-jquery library for 2.*.