test eax, ecx

[mrexodia]

See keystone-engine/keystone#91

[bSr43]

If you want a cleaner fix, you can proceed to these modifications in the file X86GenDisassemblerTables.inc:

• line 18923, change 88 to 87 (instruction TEST8rr)
• line 18835, change 69 to 73 (instruction TEST16rr)
• line 18863, change 69 to 73 (instruction TEST32rr)
• line 18891, change 43 to 76 (instruction TEST64rr)

It will change the operand specifier to the proper one, where the operands are inverted.

Sorry for not providing the DIFF, it is not possible for me right now 😊

[mrexodia]

Thanks, that is a good idea. I will send a pull request...

…

On Wed, 28 Dec 2016 at 12:20, Vincent Bénony ***@***.***> wrote: If you want a cleaner fix, you can proceed to these modifications in the file *X86GenDisassemblerTables.inc*: - line 18923, change 88 to 87 (instruction *TEST8rr*) - line 18835, change 69 to 73 (instruction *TEST16rr*) - line 18863, change 69 to 73 (instruction *TEST32rr*) - line 18891, change 43 to 76 (instruction *TEST64rr*) It will change the *operand specifier* to the proper one, where the operands are inverted. Sorry for not providing the DIFF, it is not possible for me right now 😊 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#702 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWCmc7R4RQ0YF7cwMGF--taT_O2Z9Nhks5rMkYWgaJpZM4I16Yd> .

[mrexodia]

@aquynh what are those files generated from? Perhaps it's better to change the source since the _reduce.inc has different constants for those instructions...

[ant1]

It seems those files are generated by llvm-tblgen, and the bug was fixed in llvm r233686

http://llvm.org/viewvc/llvm-project?view=revision&revision=233686
https://llvm.org/bugs/show_bug.cgi?id=22995

[aquynh]

fixed now, please confirm.

[mrexodia]

Works correctly now, thanks a lot!