link render error

[peterpu806-ctrl]

I've noticed that when rendering links, an extra underscore appears at the end if the URL

contains underscores

This is my test repository: https://github.com/peterpu806-ctrl/comarkTest/tree/master

[farnabaz]

I can't see this example in your repository, Also it seems that you are using cloned version of Comark.

But from the screenshot, I think it is not an underscore but an space with underline style. Could you update repository with example and using latest Comark packages?

I would also appreciate if you can deploy it too. You can use Vercel, it will be as easy as running npm vercel deploy

Update: I can see that example exists in master branch. and indeed it is a bug 👍

[peterpu806-ctrl]

ok~ thank you very much!

[peterpu806-ctrl]

#129 (Could you please take a look at this issue? Thank you! )

[farnabaz]

@peterpu806-ctrl I have another PR ready for that too, do you mind using pr release to verify both fixes?

[peterpu806-ctrl]

It’s feasible, no issues.
Hello, After testing, the BUG in the link still exists. When changing its position, it reappears, causing the link to be invisible or partially displayed.

the issue of frequent re-rendering of components when passing parameters via Yaml is still not resolved.

Could you please take a look at this issue? I'm waiting for it. Thank you very much. This is the latest test repo (master branch): https://github.com/peterpu806-ctrl/comarkTest/tree/master

[farnabaz]

About the links: this is not related to Comark and it how markdown-it treats the urls.
I suggest using <link> syntax for now and do not rely on link detection untill we find a proper solution. (You can check markdown-t behavior here https://markdown-it.github.io/)

And about the re-render, it seems that the fix was missing in the PR, I merged PR in main branch, just tru using main branch and will be fixed.

[peterpu806-ctrl]

ok！ thank you very much !

[farnabaz]

Another hint for the links:
Having _ (underscore) in domain names are invalid, thats because markdown-it's linkify does not work fine with underscore. link](https://www.ssl.com/faqs/underscores-not-allowed-in-domain-names/)