Broken CLI in dev branch

[hudochenkov]

CLI was broke with latests commits in dev.

Before include-specified.scss:

.block {
    color: black;

    @extend .hey;
    @extend %ho;

    @include media("lap") {
        color: green;
    }
    @include media("palm") {
        color: red;
    }
    @include last;
    @include hide-text;
}

After:

[object Promise]

.csscomb.js:

{ "sort-order": [

["$extend", "color"]

]}

[tonyganch]

Should be ok now. Though I've made it as a hotfix and have not added any tests yet 🙊
Please let me know if the problem remains.

[hudochenkov]

CLI is working, but result it very broken. Before and config as in first message. After:

.block
{
    color: black;

    @extend .hey;
    @extend %ho;
    @include media('lap')
    {
        color: green;
    }@include media('palm')
    {
        color: red;
    }@include last;
    @include hide-text;


}

[hudochenkov]

Also some problem with csscomb installation. scripts/postinstall.sh contains unused line:

cd ./node_modules/gonzales-pe && npm i && npm run build && cd -

And npm run build I have to run manually after npm install.

[tonyganch]

@hudochenkov

(1) csscomb installation
I've removed unused line from postinstall.sh, thank you, but it does not break anything anyway: if there is no gonzales-pe folder inside node_modules the command will just stop and go to next line, to csscomb-core installation.

(2) npm run build
Do you mean that inside csscomb project you need to run npm install && npm run build though you expect csscomb's files to be built in postinstall step automatically?

[tonyganch]

@hudochenkov

CLI is working, but result it very broken

It's anything but CLI. I've added a failing test to work with: b3d0ff1

[hudochenkov]

(2) Yes, I'm expect that after npm install everything is ready for work. Maybe you should add npm run build to postinstall like you do for dependencies?

[tonyganch]

@hudochenkov, actually, no. There are sources that are meant for developing (src directory) and built files that should be used "in production" (lib directory). When we publish csscomb package, we publish only lib files: https://github.com/csscomb/csscomb.js/blob/dev/package.json#L54 When a person runs npm install csscomb, the package has neither src files nor babel to build them. So if we add postinstall step with npm run build, installation will fail.

We could check whether there is src directory, but I find it confusing and think that running npm run build is not such a time-consuming task especially since it's done automatically within npm test task. (I assume here that you clone sources for developing purpose and your main goal is writing and running tests.)

[hudochenkov]

I didn't think about all this processes. Thank you for explanation! Totally agree with you now.

P. S. One more thing not related to this issue. Why you mention me in your comments? It's for triggering notifications for me? :)

[tonyganch]

@hudochenkov, yes, because I don't know how you have filters set up in your mail and don't want you to miss a comment :)