Skip to content

add spring configuration metadata#3553

Merged
nobodyiam merged 4 commits into
apolloconfig:masterfrom
vdiskg:spring-configuration-metadata
Feb 23, 2021
Merged

add spring configuration metadata#3553
nobodyiam merged 4 commits into
apolloconfig:masterfrom
vdiskg:spring-configuration-metadata

Conversation

@vdiskg
Copy link
Copy Markdown
Contributor

@vdiskg vdiskg commented Feb 19, 2021

spring configuration metadata let IDE developers offer contextual help and code completion as users are working with properties or yml files

the metadata Include the following keys

apollo.accesskey.secret
apollo.autoUpdateInjectedSpringProperties
apollo.meta
apollo.bootstrap.eagerLoad.enabled
apollo.bootstrap.enabled
apollo.bootstrap.namespaces
apollo.cluster
apollo.property.order.enable
app.id

Copy link
Copy Markdown
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature looks great! There are some minor suggestions as below.

"description": "apollo client app id. if it's empty apollo will only load public namespace configurations!."
}
]
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about adding more configuration metadata like apollo.cacheDir

vdiskg and others added 2 commits February 22, 2021 09:41
Co-authored-by: Jason Song <nobodyiam@gmail.com>
@vdiskg vdiskg force-pushed the spring-configuration-metadata branch from c70f811 to c2c7354 Compare February 22, 2021 02:19
Copy link
Copy Markdown
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 0a7b760 into apolloconfig:master Feb 23, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Mar 16, 2021
@vdiskg vdiskg deleted the spring-configuration-metadata branch April 22, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants